----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/696/#review1249 -----------------------------------------------------------
Ship it! Looks ok, but boy is that read() function in the LSQ getting unwieldy. - Korey On 2011-05-16 14:39:09, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/696/ > ----------------------------------------------------------- > > (Updated 2011-05-16 14:39:09) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Fix issue w/wbOutstading being decremented multiple times on blocked > cache. > > If a split load fails on a blocked cache wbOutstanding can be decremented > twice if the first part of the split load succeeds and the second part fails. > Condition the decrementing on not having completed the first part of the load. > > > Diffs > ----- > > src/cpu/o3/iew.hh fb0e525008c5 > src/cpu/o3/iew_impl.hh fb0e525008c5 > src/cpu/o3/lsq_unit.hh fb0e525008c5 > > Diff: http://reviews.m5sim.org/r/696/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
