----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/708/#review1250 -----------------------------------------------------------
Ship it! If you could just make this one change that would be great. configs/common/Options.py <http://reviews.m5sim.org/r/708/#comment1736> could you name this prog-interval or something similar. _ is non standard for us. - Ali On 2011-05-19 23:34:33, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/708/ > ----------------------------------------------------------- > > (Updated 2011-05-19 23:34:33) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > configs: cleanup redundant/unused options > maxinsts & max_inst redundant > prog_intvl and profile seem redundant, but profile looks to be unused > add -p option for progress intervals > > > Diffs > ----- > > configs/common/Options.py d1ce92fd3245 > configs/common/Simulation.py d1ce92fd3245 > > Diff: http://reviews.m5sim.org/r/708/diff > > > Testing > ------- > > > Thanks, > > Korey > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
