----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/710/#review1254 -----------------------------------------------------------
Ship it! I didn't compile it or anything, but it looks good to me. - Nathan On 2011-05-23 16:48:45, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/710/ > ----------------------------------------------------------- > > (Updated 2011-05-23 16:48:45) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > syscall emul: fix Power Linux mmap constant, plus other cleanup > > We were getting a spurious warning in the regressions that turned > out to be due to having the wrong value for TGT_MAP_ANONYMOUS for > Power Linux, but in the process of tracking it down I ended up > doing some cleanup of the mmap handling in general. > > > Diffs > ----- > > src/arch/power/linux/linux.hh 3f37cc5d25bc > src/sim/process.cc 3f37cc5d25bc > src/sim/syscall_emul.hh 3f37cc5d25bc > > Diff: http://reviews.m5sim.org/r/710/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev