That does look nice. It can be a lot of work slogging through O3 trace output to figure out what's going on, and I expect this to make that a lot easier. I glanced through the code and didn't see anything particularly objectionable, although I wouldn't necessarily consider that a thorough review :-P.
Gabe On 05/26/11 22:20, Steve Reinhardt wrote: > Cool! I haven't looked at the code yet, but the output looks nice. > > Steve > > On Thu, May 26, 2011 at 8:19 PM, Ali Saidi <sa...@umich.edu> wrote: >> Anyone that is curious what this looks like... lets try the picture again... >> >> >> >> >> Ali >> >> On May 26, 2011, at 9:19 PM, Ali Saidi wrote: >> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.m5sim.org/r/721/ >>> ----------------------------------------------------------- >>> >>> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >>> Nathan Binkert. >>> >>> >>> Summary >>> ------- >>> >>> O3: Create a pipeline activity viewer for the O3 CPU model. >>> >>> Implement a pipeline activity viewer as a python script >>> (util/o3-pipeview.py) >>> and modified O3 code base to support an extra trace flag (O3PipeView) for >>> generating traces to be used as inputs by the tool. >>> >>> >>> Diffs >>> ----- >>> >>> src/cpu/SConscript 3f37cc5d25bc >>> src/cpu/o3/commit_impl.hh 3f37cc5d25bc >>> src/cpu/o3/decode_impl.hh 3f37cc5d25bc >>> src/cpu/o3/dyn_inst.hh 3f37cc5d25bc >>> src/cpu/o3/fetch_impl.hh 3f37cc5d25bc >>> src/cpu/o3/iew_impl.hh 3f37cc5d25bc >>> src/cpu/o3/inst_queue_impl.hh 3f37cc5d25bc >>> src/cpu/o3/rename_impl.hh 3f37cc5d25bc >>> util/o3-pipeview.py PRE-CREATION >>> >>> Diff: http://reviews.m5sim.org/r/721/diff >>> >>> >>> Testing >>> ------- >>> >>> >>> Thanks, >>> >>> Ali >>> >>> _______________________________________________ >>> gem5-dev mailing list >>> gem5-dev@m5sim.org >>> http://m5sim.org/mailman/listinfo/gem5-dev >>> >> >> _______________________________________________ >> gem5-dev mailing list >> gem5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/gem5-dev >> >> > _______________________________________________ > gem5-dev mailing list > gem5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
