Dear Reinhardt, Thanks for your response, But If possible please explain you answer more. I cannot understand following statement: "you'd have to permanently commit your change to your local repository in order to post it for review."
Thanks On Thu, May 17, 2012 at 5:56 PM, Steve Reinhardt <[email protected]> wrote: > I don't believe you even need to use mercurial queues to use postreview. > If you're not using queues, you'd have to permanently commit your change > to your local repository in order to post it for review. > > Steve > > > On Thu, May 17, 2012 at 5:49 AM, Korey Sewell <[email protected]> wrote: > >> I'm not sure why you are not using mercurial patchqueues, but you should >> to make this easier. >> >> If you are using patchqueues, you can also download the reviewboard >> extension. >> >> Once you do that, here are some basic instructions that Gabe Black helped >> me with a while back (years ago?!): >> >> * Edit your .hg/hgrc to point to the reviewboard download: >> reviewboard = /home/gblack/m5/mercurial-reviewboard >> >> You'd put the path to wherever you put the review board extension. Under >> [reviewboard] I have: >> >> [reviewboard] >> server = http://reviews.m5sim.org >> user = gblack >> target_groups = Default >> >> * Make sure the patch you want to post is at the top of your patchqueue >> >> * Once the patch you want to submit is the top patch and then run >> hg postreview -o >> to post it initially. >> >> It will say something about posting a draft, and then if you go to >> reviewboard you can look it over and actually publish it. >> >> * If you want to update a review, you go to review board and figure out >> what number it is (I get that from the URL, but it may also be somewhere >> else) and then, if that number is 123 for example, run this command: >> hg postreview -u -e 123 -o >> >> >> >> >> On Thu, May 17, 2012 at 8:19 AM, Hamid Reza Khaleghzadeh < >> [email protected]> wrote: >> >>> Hello, >>> >>> I have created a diff as following: >>> >>> "diff -ru Gem5_source_code modified_Gem5_source_code > Patch_file" >>> >>> I apply the patch file to Gem5_source_code and it can modify source code >>> correctly. But there is a problem when the patch file is uploaded to Gem5 >>> review board by Web UI. I encounter with "didn't apply cleanly" in tab View >>> Diff. Could tell me what is wrong? >>> >>> Thanks >>> >>> _______________________________________________ >>> gem5-users mailing list >>> [email protected] >>> http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users >>> >> >> >> >> -- >> - Korey >> >> _______________________________________________ >> gem5-users mailing list >> [email protected] >> http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users >> > > > _______________________________________________ > gem5-users mailing list > [email protected] > http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users > -- Hamid Reza Khaleghzadeh http://hkhaleghzadeh.webs.com
_______________________________________________ gem5-users mailing list [email protected] http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users
