One more thing about this patch that I did not like. The patch changed the
entries in config.ini file. Routers are no longer children of topology,
but are child of some external link to which they are attached. In fact,
they are no longer named as "router<id>". Was this intentional? Is it
possible to restore the naming to what it was before?
--
Nilay
On Thu, 12 Jul 2012, Jason Power wrote:
I also don't know why we can't move instantiateTopology to Ruby.py. Brad,
at one point you said that the topologies had to be created in compiled
python, not in the interpreted python during startup. Do you know the
reason for this? Or maybe that requirement changed at some point.
I just moved the function and ran a few tests and it seemed to work. I
didn't test FS mode, but I don't see any reason why the topology creation
for FS would be any different from SE. Do either of you disagree?
So I'll post a patch which moves that function to Ruby.py and cleans up
some other things tomorrow.
Jason
PS, Brad: BankedArray.cc and BankedArray.hh also don't have the AMD
copyright stuff on it. I'll let you take care of it since you have
commit privilege.
------
Jason Power
University of Wisconsin-Madison,
Department of Computer Sciences
[email protected]
On Thu, Jul 12, 2012 at 3:43 PM, Beckmann, Brad <[email protected]>wrote:
Also I just realized we need to get an AMD header on that file if it
will remain.****
** **
Brad****
** **
** **
*From:* Beckmann, Brad
*Sent:* Thursday, July 12, 2012 1:31 PM
*To:* 'Nilay Vaish'
*Cc:* Jason Power ([email protected])
*Subject:* RE: Review Request: ruby: changes how Topologies are created***
*
** **
Good point. I don?t see why we have to create a separate file for the
function, but possibly Jason has ideas of what more will be added to
TopologyCreator.py.****
** **
Jason, could you elaborate?****
** **
Brad****
** **
** **
*From:* Nilay Vaish [mailto:[email protected]] *On Behalf Of *Nilay
Vaish
*Sent:* Thursday, July 12, 2012 5:15 AM
*To:* Nilay Vaish; Beckmann, Brad; Default
*Subject:* Re: Review Request: ruby: changes how Topologies are created***
*
** **
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1285/ ****
** **
Brad, why can we not move the function instantiateTopology() to Ruby.py?****
** **
- Nilay****
** **
_______________________________________________
gem5-users mailing list
[email protected]
http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users
