Hi Rizwana, I look forward to see the patch.
Note that open-adaptive and closed-adaptive behave differently. In the open case we only close if there is no hit, and there is a bank conflict. For the closed one we close if there are no hits (ignoring if there are conflicts or not). If this is till captured then by all means go ahead and simplify the code. Perhaps add some more comments to make this more clear. Andreas From: Rizwana Begum via gem5-users <[email protected]<mailto:[email protected]>> Reply-To: Rizwana Begum <[email protected]<mailto:[email protected]>>, gem5 users mailing list <[email protected]<mailto:[email protected]>> Date: Tuesday, 3 February 2015 05:01 To: gem5 users mailing list <[email protected]<mailto:[email protected]>> Subject: [gem5-users] DRAMCtrl auto precharge logic simplification Hello All, I think the if condition that's checking to find the right condition for auto-precharge in doDRAMAccess() can be simplified Original : while (!(got_more_hits && (got_bank_conflict || pageMgmt == Enums::close_adaptive)) && p != queue.end()) { Simplified: while (!got_more_hits && p != queue.end()) { The above simplification comes as both close-adaptive and open-adaptive policies keep row open if a hit is found. Otherwise the search for a hit continues until the end of the queue and during the search got_bank_conflict gets updated anyways. I am planning to put this simplification on reviewboard (along with another bug fix that I have). I would appreciate it if anyone using DRAM controller has any comments regarding this simplification. Thank you, -Rizwana -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
_______________________________________________ gem5-users mailing list [email protected] http://m5sim.org/cgi-bin/mailman/listinfo/gem5-users
