[AMD Public Use]

Hi Sampad,

I have not tested VIPER atomics, but I think we are relying on the backing 
store to actually perform the atomic. You are correct that 
DataBlock::atomicPartial calls the atomic functor through the WriteMask object; 
however, this is not what VIPER uses.

If you look at RubyPort::MemSlavePort::hitCallback you will see that it calls 
AbstractMemory::access, which calls the atomic functor. I think what is 
happening is that when the GPUCoalescer receives a response and the atomic is 
complete (i.e., ad_atomicDone action) GPUCoalescer::atomicCallback is being 
called, which reaches to AbstractMemory::access. So the call stack should be as 
follows:

#0  AtomicOpCAS<unsigned int>::execute
#1  AbstractMemory::access
#2  RubyPort::MemSlavePort::hitCallback
#3  GPUCoalescer::completeHitCallback
#4  GPUCoalescer::hitCallback
#5  GPUCoalescer::atomicCallback
#6 *_Controller::ad_atomicDone

Let me know if you are noticing something different.

Best regards,
Alex

From: Sampad Mohapatra via gem5-users <[email protected]>
Sent: Tuesday, August 25, 2020 8:22 AM
To: gem5 users mailing list <[email protected]>
Cc: Sampad Mohapatra <[email protected]>
Subject: [gem5-users] GCN3 - SLICC - GPU_VIPER-TCC.sm and GPU_TCP-TCP.sm 
Correctness

[CAUTION: External Email]
Hello,

In GPU_VIPER-TCC.sm and GPU_TCP-TCP.sm, in action at_atomicThrough present in 
both files,
the out message Type is CoherenceRequestType:Atomic and the message size is 
MessageSizeType:Data,
but there is no data being sent. Is this correct behaviour ?

Either data is not being sent or the message size should be some other type.
Please advise.

Thank you,
Sampad Mohapatra

[https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif]<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avast.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Dwebmail%26utm_term%3Dicon&data=02%7C01%7Calexandru.dutu%40amd.com%7C17818025e6904fdad67c08d8490ad57f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637339658166161496&sdata=6%2BrBbDhCV%2Fko%2Fs5LCbbTXhY68%2BoMeZosoS9lcs9FGdg%3D&reserved=0>
Virus-free. 
www.avast.com<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avast.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Dwebmail%26utm_term%3Dlink&data=02%7C01%7Calexandru.dutu%40amd.com%7C17818025e6904fdad67c08d8490ad57f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637339658166161496&sdata=owEbFVKkg2q5ItZI0rA3%2FFepEQtv%2Bil%2Bfq2fVH7JoUQ%3D&reserved=0>

_______________________________________________
gem5-users mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to