Hi Matt,
The following condition is missing in t_allocateTBE, but the corepair sends
a message with VicDirty - CoherenceRequestType.
if (in_msg.Type == CoherenceRequestType:VicDirty) {
tbe.DataBlk = in_msg.DataBlk;
}
P.S.: I am not sure whether the complete block should be replaced or just
partially copied.
Thanks,
Sampad
On Sat, Oct 23, 2021 at 2:44 PM Matt Sinclair <mattdsinclair.w...@gmail.com>
wrote:
> (Resending to mailing list)
>
> Hi Sampad,
>
> There are lines directly below the one I pointed to that do potentially
> overwrite the data there. But I am not 100% sure -- Brad and Matt P, CC'd
> may know better or see something I'm missing.
>
> Matt
>
> On Sat, Oct 23, 2021 at 1:37 PM Sampad Mohapatra <su...@psu.edu> wrote:
>
>> Yes, but the data is coming from the directory and not the incoming
>> message, which has the actual data.
>>
>> Should it not be:
>> *tbe.DataBlk := in_msg.DataBlk;*
>>
>> i.e., store the dirty victim block data in the tbe.
>>
>> Thanks,
>> Sampad
>>
>> On Sat, Oct 23, 2021 at 1:00 PM Matt Sinclair <
>> mattdsinclair.w...@gmail.com> wrote:
>>
>>> I am not sure I understand completely what you're getting at, but it
>>> appears the allocation of the TBE entry does store the data:
>>> https://gem5.googlesource.com/public/gem5/+/refs/heads/develop/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm#878
>>>
>>> Matt
>>>
>>> On Thu, Oct 21, 2021 at 11:08 PM Sampad Mohapatra via gem5-users <
>>> gem5-users@gem5.org> wrote:
>>>
>>>> Hello All,
>>>>
>>>> I was looking at the MOESI_AMD_Base-CorePair.sm and
>>>> MOESI_AMD_Base-dir.sm and am not quite sure if the following sequence of
>>>> events are correct or not. Can you please verify?
>>>>
>>>> /////////////////////////
>>>> At CorePair -> invokes action "vd_victim", which sends a data block
>>>> with outgoing message.
>>>>
>>>> At Directory -> undergoes "transition(U, VicDirty, BL)" on message
>>>> reception, but doesn't store the received data block in the generated TBE
>>>> and the message is popped out/discarded.
>>>> /////////////////////////
>>>>
>>>> Is the above expected behaviour ?
>>>>
>>>> Thanks and regards,
>>>> Sampad Mohapatra
>>>> _______________________________________________
>>>> gem5-users mailing list -- gem5-users@gem5.org
>>>> To unsubscribe send an email to gem5-users-le...@gem5.org
>>>> %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
>>>
>>>
_______________________________________________
gem5-users mailing list -- gem5-users@gem5.org
To unsubscribe send an email to gem5-users-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
