Suresh,

thanks for the review.

Authors, if you'd like to incorporate any of these suggestions, please email me a corresponding RFC Editor Note.

Lars


On 2007-6-4, at 23:12, ext Suresh Krishnan wrote:
I am the assigned Gen-ART reviewer for
draft-ietf-ips-iscsi-impl-guide-08.txt

For background on Gen-ART, please see the FAQ at
<http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html>.

Please resolve these comments along with any other Last Call comments
you may receive.

Summary: This draft is ready for publication, but I have some suggestions.

Comments: Overall the draft is well written and has a really well written IANA Considerations section.

Minor
=====

* Section 4.1.2 c

"     c. Should receive the TMF Response concluding all the tasks in
          the set of affected tasks. "

I am not sure of the intent of the sentence, but I believe it to be normative. So I think the "Should" needs to be replaced with a SHOULD.

* It is really unclear from the draft how to differentiate between the following types of information
  - Updates to RFC3720
  - New behavior on top of RFC3720
  - Clarifications and implementation advice

since they are intermingled throughout the document.

I tried to skim through RFC3720 but the document is HUGE. It would be really helpful to have a section in this draft listing just the updates made to RFC3720 so that people trying to implement just the updates can easily find such info in the document.

e.g.

Topic           Section in draft        Updated Section in RFC3720
R2T Ordering    3.2                     10.8
...

* For section 11.2 iSCSI Opcodes, the document mentions the following

"Fields to record in the registry: Assigned value, Who can
originate (Initiator or Target), Operation Name and its
associated RFC reference"

Since the op codes can also be assigned using the Expert Review process, it should probably mention that the RFC reference is optional.

Editorial
=========

* RFC2119 occurs twice in the references. Once as normative and once as informative


Cheers
Suresh


Lars


Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Gen-art mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/gen-art

Reply via email to