Suresh, Thank you for the review. Regarding Section 5: The Length can be either 1 or 2 octets. 4271 defines Attr Flags. Bit 0 is the Optional bit; Bit 1 is the Transitive bit; Bit 3 is the Extended length bit.
This document specified that bits 0 and 1 must be set to 1 (Optional + transitive). The Extended length bit must be set according to the attribute payload as per 4271. The convention is the same as for any other BGP attribute. I'll add a clarification to this effect. Regarding security considerations: - The resource management considerations exist regarding routes as well as attributes, with or without this specification. I don't mind highlighting it, if you believe that improves the specification. thanks, Pedro. On Tue, Jun 7, 2011 at 3:51 PM, Suresh Krishnan <[email protected]> wrote: > I have been selected as the General Area Review Team (Gen-ART) reviewer > for this draft (for background on Gen-ART, please see > http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html). > > Please wait for direction from your document shepherd or AD before > posting a new version of the draft. > > Document: draft-ietf-l3vpn-ibgp-07 > Reviewer: Suresh Krishnan > Review Date: 2011/06/07 > IESG Telechat date: 2011/06/09 > > Summary: This draft is ready for publication as a Proposed Standard but > it has two minor issues. > > Minor > ===== > > * Section 5 > > Since the Extended Length bit is not being set in the Attribute Flags, the > Length can only be 1 octet (as opposed to 1 or 2 octets as shown in the > figure right? This needs to be clarified. > > * Security Considerations > > Since the ATTR_SET can contain arbitrary customer attributes, is it possible > that a set of customers can perform a memory exhaustion attack on the PE > routers? I understand the same can occur when the customer is using > communities but I think it is worth mentioning. > > Thanks > Suresh > _______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art
