Elwyn: Thanks for sending in the review.
Sue -----Original Message----- From: Elwyn Davies [mailto:[email protected]] Sent: Thursday, August 23, 2012 8:28 AM To: General Area Review Team Cc: [email protected] Subject: Spam:*******, Gen-art LC review of draft-ietf-idr-as0-05 I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> . Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-idr-as0-05.txt Reviewer: Elwyn Davies Review Date: 22 August 2012 IETF LC End Date: 22 August 2012 IESG Telechat date: (if known) - Summary: Almost ready. Major issues: None. Minor issues: s1, para 2: > [RFC6491] specifies that AS number zero in a ROA is used to mark an > NLRI which is to be marked as Invalid. This is not what s4 of RFC 6491 says although ultimately this is (probably) the way in which it is intended to be used. RFC 6491 just says that an 'AS 0 ROA' is used to mark a prefix and all its more specific prefixes as not to be used in a routing context. s1, para 4: > As at least two implementations discard routes containing AS 0, and > to allow approaches such as the above, this document codifies this > behavior. This sentence is not entirely clear as to what behavior is being codified. It could be just discarding routes with AS 0 or the the use of AS 0 to mark prefixes that shouldn't be routed. Please make this easier to parse. This is partly because of the over interpretation of RFC 6491 mentioned in the previous comment. Nits/editorial comments: Abstract: Acronym BGP needs expanding. s1: Acronyms ROA, AS and NLRI need expanding. s2: It would be worth reinforcing that the behaviors being modified here are currently specified in RFC 4271. Arguably relevant section numbers would help. s4: Acronym RPKI needs expanding. s4, para 2: > security gotchas often lurk in the undefined spaces This is slang and cliche that may be difficult for non-US speakers to understand. _______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art
