Hi Suresh, Please see inline for my comment to your point raised.
Thanks. Young -----Original Message----- From: Suresh Krishnan [mailto:[email protected]] Sent: Monday, March 02, 2015 3:55 AM To: draft-ietf-ccamp-gmpls-general-constraints-ospf-te....@tools.ietf.org; General Area Review Team Subject: Gen-ART Telechat review of draft-ietf-ccamp-gmpls-general-constraints-ospf-te-09.txt I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-ccamp-gmpls-general-constraints-ospf-te-09.txt Reviewer: Suresh Krishnan Review Date: 2015/03/02 IESG Telechat date: 2015/03/05 Summary: This draft is ready for publication as a Proposed Standard, but I do have some comments you may wish to address. Minor: * Section 5 Isn't separating static and dynamic info of the same TE link another method of scaling? (e.g. encoding the Port Label Restrictions sub-TLV into a separate top level link TLV and advertising in a separate LSA) If so, suggest adding a subsection here to describe it. YOUNG>> In this draft, the intent of the Port Label Restriction (which is a link TLV) is to introduce a new constraint that needs to be known in path computation, not to separate dynamic TE info from static TE info. Port Label Restriction is actually quite static (as Section 3.1 (second paragraph). * Security Considerations: I have an uneasy (potentially unjustified) feeling about the lack of any specific security considerations for the Connectivity Matrix sub-TLV. It looks pretty compute intensive to me. Somebody should probably take a look at the DoS possibilities with a multiple complex decomposed Connectivity Matrices. YOUNG>> I am not a security expert, but the decomposition of the connectivity matrix into multiple matrices is due to the IP MTU limit that would result a split of the info into multiple LSAs. This is a well-known technique in OPTF-TE and has been used for some time. As far as I know, this has not been an issue of security. What do you think? * IANA Considerations: Looking at the IANA registry, the Sub-TLVs do not have the text sub-TLV tag attached to them. Suggest renaming to OLD: TBD1 | Connectivity Matrix sub-TLV | [This.I-D] NEW: TBD1 | Connectivity Matrix | [This.I-D] OLD: TBD2 | Port Label Restrictions sub-TLV | [This.I-D] NEW: TBD2 | Port Label Restrictions | [This.I-D] YOUNG>> Yes, I agree. Thanks Suresh _______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art
