I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, 
please see the FAQ at



<https://urldefense.proofpoint.com/v2/url?u=http-3A__wiki.tools.ietf.org_area_gen_trac_wiki_GenArtfaq&d=AwICAg&c=BFpWQw8bsuKpl1SgiZH64Q&r=I4dzGxR31OcNXCJfQzvlsiLQfucBXRucPvdrphpBsFA&m=hGLCrvRMbwg7aF87DUcj1kzIZxtq-RxIeVZwskYlZUw&s=JAEyywKQRPrtTGWFwQ10cWxvPlWJJMPtFco6XfIaGDg&e=
 
<https://urldefense.proofpoint.com/v2/url?u=http-3A__wiki.tools.ietf.org_area_gen_trac_wiki_GenArtfaq&d=AwICAg&c=BFpWQw8bsuKpl1SgiZH64Q&r=I4dzGxR31OcNXCJfQzvlsiLQfucBXRucPvdrphpBsFA&m=hGLCrvRMbwg7aF87DUcj1kzIZxtq-RxIeVZwskYlZUw&s=JAEyywKQRPrtTGWFwQ10cWxvPlWJJMPtFco6XfIaGDg&e=%20>
 >.



Please resolve these comments along with any other Last Call comments you may 
receive.



Document: draft-ietf-hybi-permessage-compression-21

Reviewer: Dan Romascanu

Review Date: 6/16/15

IETF LC End Date: 6/24/15

IESG Telechat date: 7/9/15



Summary: Ready with minor issues



I do not know if this is an issue, but I am asking the question. Some 
implementations are mentioned in the write-up, but they seem to have been 
written and deployed based on very old versions of the document - 05 and 
earlier, dating three years back. I am wondering if this is a problem of the 
write-up not being updated. If not - have the changes brought to the document 
since draft-05 impacted the negotiation and algorithms described in the 
document?



Major issues:



Minor issues:



1.       In Section 5:



   The server must keep the original
   bytes of data that it recently compressed and sent to the client.
   The client must keep the result of decompressing the bytes of data
   that it recently received from the server.

   The two 'must' here seem to deserve capitalization.



2.       In Section 8.2.1:



Note that

   for non-final fragments, the removal of 0x00 0x00 0xff 0xff must not

   be done.

'must not' here seems to deserve capitalization.



Nits/editorial comments:



1.       In Section 4: 'One PMCE extension is defined ...' - the word extension 
can be dropped, E already stands for extension

2.       In Section 10.2 - It would be good to explain in 'Meaning' the 
significance of the values 0 and 1 of the RSV1 bit

3.       In section 11:  s/Thank you to the following people/Thanks to the 
following people/





_______________________________________________
Gen-art mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/gen-art

Reply via email to