Dear Peter, On Sun, Jul 19, 2026 at 04:27:12AM -0700, Peter Yee via Datatracker wrote: > Document: draft-ietf-sidrops-aspa-profile > Title: A Profile for Autonomous System Provider Authorization > Reviewer: Peter Yee > Review result: Ready with Nits > > Minor issues: > > Page 3, 1st paragraph after lettered items, 1st sentence: I’m having troubles > understanding how this specification constitutes a profile. A profile of what? > As far as I can see, it specifies an object, its semantics, and related > procedures. Admittedly, that object ends up inside of a CMS wrapper, but I > don’t really think of that as making it a profile of a CMS-protected object. > To > be clear, this is a really minor issue, and I could be wrong about what > constitutes a profile.
I think the word 'profile' can just be removed from that sentence. I love simple English. > Nits/editorial comments: > > Page 3, 4th paragraph after lettered items, 1st sentence: change "CMS > [RFC5652] > protected" to "CMS-protected [RFC 5652]". Change "content type" to > "content-type". Thanks > Page 6, section 3.3, 1st bullet item: change "CustomerASID" to "customerASID". Thanks! > Page 6, section 3.3, 4th bullet item: change "An" to "A". Thanks > Page 7, section 5.2, 1st sentence: Should "CAs" be "CAS"? I’m unclear which > entity does the signing, but if it is the customer AS, then it should be > "CAS". Good point, this issue was also flagged by Srihari's review: https://mailarchive.ietf.org/arch/msg/sidrops/BfexxY7IlynCTUjkw5SuXaH90D8/ The "CAs" here meant Certification Authorities. I have attempted to fully disambiguate CAS vs CAS in the next revision. > Page 8, 1st paragraph, 3rd sentence: insert "as" between "CAS" and "invalid". > Append a comma after "e.g." Ah thanks, that "e.g." should've been an "i.e." :-) Thanks Peter, I believe all your feedback has been incorporated through: https://github.com/QratorLabs/ASPA/commit/5761a7ae2408d9833d05b64ac0f2c9ee50917a3f Kind regards, Job _______________________________________________ Gen-art mailing list -- [email protected] To unsubscribe send an email to [email protected]
