On Sun, 2008-12-21 at 19:58 +0800, Cedric Vivier wrote: > Salut Seb, > > Cumulative patch according to the review. > > On Sun, Dec 21, 2008 at 3:37 AM, Sebastien Pouliot > <[email protected]> wrote: > > + try { > > + new Regex (pattern); > > + } catch (Exception e) { > > Is it possible to catch something more specific than > Exception ? this > should have triggered something in "make self-test". > > The set of possible exceptions is not documented afaik, and is > potentially different with regards to runtime and runtime version. > Maybe I could catch both TypeInitializationException and > ArgumentException, but in this case we might miss exceptions that > could be thrown in some scenarios (such as very complex regexes and/or > different runtime versions).
Ok, I kind of feared that ;-) > Yup, it triggers something in self-test, if we stay with Exception > I'll add it in the self-test.ignore list indeed. Just add a comment in the rule source (copy+paste above) and then commit everything into SVN. Thanks! Sebastien --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Gendarme" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/gendarme?hl=en -~----------~----~----~----~------~----~------~--~---
