On Sat, 26 Apr 2025 at 11:51, sebb <seb...@gmail.com> wrote:

> On Sat, 26 Apr 2025 at 11:34, Niall Pemberton <niall.pember...@gmail.com>
> wrote:
> >
> > On Sat, 26 Apr 2025 at 11:23, sebb <seb...@gmail.com> wrote:
> >
> > > On Sat, 26 Apr 2025 at 10:53, Niall Pemberton <
> niall.pember...@gmail.com>
> > > wrote:
> > > >
> > > > On Sat, 26 Apr 2025 at 08:27, sebb <seb...@gmail.com> wrote:
> > > >
> > > > > On Sat, 26 Apr 2025 at 01:17, Niall Pemberton <
> > > niall.pember...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > On Sat, 26 Apr 2025 at 01:04, sebb <seb...@gmail.com> wrote:
> > > > > >
> > > > > > > On Sat, 26 Apr 2025 at 00:58, Niall Pemberton <
> > > > > niall.pember...@gmail.com>
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > Sebb,
> > > > > > > >
> > > > > > > > I'm going to revert your change for multiple repos:
> > > > > > > >
> > > > > > > > Firstly on the project page it links to a list of all the Git
> > > repos,
> > > > > not
> > > > > > > to
> > > > > > > > individual ones - so it to generates an invalid link:
> > > > > > > >     https://gitbox.apache.org/repos/asf#gora-site   (anchor
> > > doesn't
> > > > > > > exist)
> > > > > > > >     https://gitbox.apache.org/repos/asf#gora (lists all the
> gora
> > > > > repos)
> > > > > > > >
> > > > > > > > I can see that you wanted them listed on the Infra JIRA
> template.
> > > > > I'll
> > > > > > > > change this to link to the list of repos. So instead of:
> > > > > > > >     https://gitbox.apache.org/repos/asf/gora.git
> > > > > > > >     https://gitbox.apache.org/repos/asf/gora-site.git
> > > > > > > > it will point to
> > > > > > > >     https://gitbox.apache.org/repos/asf#gora
> > > > > > > >
> > > > > > >
> > > > > > > I think it is important that all the repos are listed in the
> yaml,
> > > so
> > > > > > > the Infra Jira can list them all.
> > > > > > >
> > > > > >
> > > > > > I think the JIRA template is nice - but its not something that
> > > currently
> > > > > > exists and the simplicity of one link for Git is good and its
> also
> > > what
> > > > > the
> > > > > > current project pages link to,
> > > > > >
> > > > >
> > > > > The Infra Jira template corresponds to the output of the script:
> > > > > https://github.com/apache/attic/blob/main/infrajiratext.py
> > > > >
> > > > > I don't want to lose that functionality.
> > > > >
> > > > > The script currently repeats some of the checks that are done
> already,
> > > > > and generates useful information on other resources used by
> projects.
> > > > > So it seems to me that the relevant data is better in the yaml and
> > > > > then presented using the template.
> > > > >
> > > >
> > > > No, it is a pollution/duplication to put all the git repos in yaml
> when
> > > > gitbox already provides a link to all a projects git repos. I'm dead
> > > > against doing that. Better that GitBox maintains that list than all
> the
> > > > attic project's data files.
> > > >
> > > > However, I believe its possible to use a GitHub action to download
> the
> > > JSON
> > > > file from GitBox when the site generation/build is run:
> > > >     https://gitbox.apache.org/repositories.json
> > >
> > > Which is what the script infrajiratext.py uses.
> > >
> > > > If that is saved as "_data/git-repositories.json", then we can
> process
> > > that
> > > > to list the Git Repos in the Infra Template. I've added a PoC for
> that in
> > > > the template page:
> > > >
> > > >
> > >
> https://niallkp.github.io/attic-jekyll-site/templates/gora.html#attic-git
> > >
> > > Does not appear to work, as it does not list gora-site.
> > >
> >
> > Well, I hadn't added the action - but I have now and its working:
> >
> >
> https://niallkp.github.io/attic-jekyll-site/templates/gora.html#attic-git
>
> The link I see is
>
> Git: https://gitbox.apache.org/repos/asf#gora.git
>
> which does not work for me.
>
> Nor do I see a list of the repos.
>

I added a "Proof of Concept" to the page, just to show they could be listed
(if the JSON file was found) - so you were looking in the wrong place - at
the top of the page, not the Infra JIRA template

[image: image.png]

Anyway, since I got the action working to download the JSON file, I've now
removed the PoC and updated the "Infra JIRA Template" section:

https://github.com/niallkp/attic-jekyll-site/commit/28e59cc278fe77855976625b9c8db950f88d7065

Niall



> > Niall
> >
> >
> > > Also, the anchor link is incorrect.
> > >
> > > >
> > >
> https://github.com/niallkp/attic-jekyll-site/commit/4c1a9c810fce21e283146765d20bf28d5b18bb25
> > > >
> > > > So just need to work out how to configure the GH action (don't have
> time
> > > to
> > > > do that today, but perhaps next week)
> > > >
> > > > It would also allow everything to be done from the browser, rather
> > > > > than using CLI.
> > > > >
> > > > > Note: I am working on a script to generate the yaml, and have
> > > > > successfully tested generation of a PR using a GHA.
> > > > > So it should eventually be possible to invoke a GHA passing the id
> of
> > > > > a project, and have it generate a PR to add the yaml.
> > > > > No need for any CLI.
> > > > >
> > > >
> > > > Great
> > > >
> > >
> > > [snip]
> > >
>

Reply via email to