The behavior is as you specified, if the build fails the first time due to a
prereq you get a notice, after that you don't until  the build passes.
However, when a basic prereq like commons-lang or ant or xml parser failes,
and then fixes, it causes a storm of spam messages.   On the turbine dev
list, if this happens we get 20 emails, one per fulcurm component.  Which is
very annoying and causes people just to filter gump messages.

At least in the fulcurm case, we don't care if a prereq failed and then
successed..  We do care ONLY when we succeed/fail.

> -----Original Message-----
> From: Adam R. B. Jack [mailto:[EMAIL PROTECTED]
> Sent: Saturday, December 04, 2004 10:22 PM
> To: Gump code and data
> Subject: Re: Hello Gump
>
>
>
> > When a project is not built because one of the dependencies didn't build
> > and then gets build again because the dependency solved its problems,
> > the project receives an email that is has no longer a problem.
> >
> > We have concensus to feel that this is annoying and the projects should
> > be made aware of their change in status *only* when they fix their own
> > problems, not when people down the road does.
> >
> > Either we solve this, or we stop sending email until we figure out a
> > better way because this is harming our ability to make gump
> appear useful.
> >
> > WDYT?
>
> I think it'd bug me too. ;-)
>
> That said, I thought this code would've taken care of that.
>
> In actor/notify/logic.py we have:
>
>     elif entity.isSuccess():
>         #
>         # Notify on first success, after a failure.
>         #
>         if (stats.sequenceInState == 1):
>             if not STATE_PREREQ_FAILED == stats.previousState:
>                 if stats.getTotalRuns() > 1:
>
> notification=gump.actor.notify.notification.SuccessNotification(se
> lf.run,ent
> ity)
>
> So -- I'm missing something. If they failed to build due to pre-requisite
> failure they ought not get the notification. Maybe I broke
> something when I
> hacked in attempting to build from repository (previously built
> artifacts).
> I'll look into is ASAP.
>
> BTW: We really need your historical database, so we can query not
> hack. :-)
>
> regards,
>
> Adam
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to