The attached NOTICE file looks ok to me, it should also have the following two lines at the top:
Apache Pig Copyright 2008 The Apache Software Foundation See http://www.apache.org/legal/src-headers.html#notice. I think you will need to restart as to fix the NOTICE file you'll need to build a new distribution. It has been done in the past that the dev list and general@ votes on the respin are done in parallel though. ...ant On Wed, Aug 13, 2008 at 10:15 PM, Olga Natkovich <[EMAIL PROTECTED]>wrote: > Does the attached notice file look correct? > > Also, does this mean we need to restart the entire process? > > Thanks, > > Olga > > ------------------------------ > *From:* [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] *On Behalf Of *ant > elder > *Sent:* Tuesday, August 12, 2008 11:32 PM > *To:* Olga Natkovich > *Cc:* general@incubator.apache.org > > *Subject:* Re: [VOTE] Release Apache Pig 0.1.0-incubating > > Replies inline. > > ...ant > > On Wed, Aug 13, 2008 at 1:43 AM, Olga Natkovich <[EMAIL PROTECTED]>wrote: > >> Hi, >> >> Thanks for quick feedback! A couple of follow up questions inline. >> >> > -----Original Message----- >> > From: ant elder [mailto:[EMAIL PROTECTED] >> > Sent: Tuesday, August 12, 2008 12:07 AM >> > To: general@incubator.apache.org >> > Subject: Re: [VOTE] Release Apache Pig 0.1.0-incubating >> > >> > On Mon, Aug 11, 2008 at 7:26 PM, Olga Natkovich >> > <[EMAIL PROTECTED]> wrote: >> > >> > > Hi Everyone, >> > > >> > > Apache Pig dev community voted to release Pig >> > 0.1.0-incubating. We had >> > > 4 >> > > +1 votes from committers and mentors and no 0 or -1 votes. >> > (Message-ID: >> > > >> > <[EMAIL PROTECTED] >> > > >) >> > > . >> > > >> > > The artifacts are available at >> > > >> > http://people.apache.org/~olga/pig-0.1.0-candidate-4/<http://people.apache.org/%7Eolga/pig-0.1.0-candidate-4/> >> <http://people.ap >> > > ache.org/%7Eolga/pig-0.1.0-candidate-4/> >> > > >> > <http://people.apache.org/~olga/pig-0.1.0-candidate-4/<http://people.apache.org/%7Eolga/pig-0.1.0-candidate-4/> >> <http://people.a >> > > pache.org/%7Eolga/pig-0.1.0-candidate-4/> >> > > > >> > > >> > > Please vote by 6 pm on Thursday, 8/14. >> > > >> > > Olga >> > > >> > > >> > >> > The main issue is the NOTICE file is missing some copyrights >> > for the 3rd party products that are included such as javacc, >> > jsch, and jetty (jetty is embedded within the >> > pig-0.1.0-incubating-core.jar). I think this should be fixed >> > for this release. >> >> I put the licenses in separate files in the lib directory where all the >> 3rd party libraries are following Hadoop model. I did not realize that >> they had to go to the notice file. I can move them if needed. Also jetty >> is part of Hadoop distribution; is it sufficient just to have Hadoop >> license present? >> > > Having the licenses in the separate lib directory is fine but the top > NOTICE file still needs to include any attributions. For example, pig > includes javacc and the javacc license says "Copyright (c) 2003 Sun > Microsystems, Inc." and the JavaCC license says "Redistribution in binary > form must reproduce the above copyright notice", so add the pig NOTICE file > something like: > > This product includes/uses the JavaCC (https://javacc.dev.java.net/), > Copyright (c) 2003 Sun Microsystems, Inc. > > You need that for javacc, jsch, and jetty. > > >> >> > >> > Some other comments: >> > >> > If the pig-0.1.0-incubating-core.jar is to be distributed >> > separately (eg maven repo) then it needs to include >> > LICENSE/NOTICE/DISCLAIMER files. >> >> What is the DISCLAIMER file? >> > > Its the text at the bottom of the pig README, or that text can be in a file > on its own. The pig distro is fine as-is, i was just pointing out that _if_ > the pig-0.1.0-incubating-core.jar is going to be distributed seperately then > it would also need to include its own legal files. > > >> >> > The signature used to sign the distribution isn't available >> > online from a public key server, eg pgp.surfnet.nl >> >> Keys are at /www/www.apache.org/dist/incubator/pig on people.apache.org. >> Is this not the right location? >> > > Yes thats the right place, but you can also publish them to a public key > server and then if peoples clients are configured correctly the keys will be > downloaded automatically. See > http://www.apache.org/dev/release-signing.html#keyserver > > >> >> > The release should be built from an svn tag but there doesn't >> > seem to be one. >> >> I created a branch for it. Will add a tag as well. >> >> > Would be helpful to include a RAT report in the VOTE email >> >> Attached now >> >> > >> > Other than that it looks good, if the NOTICE file is updated >> > it would get my >> > +1. >> > >> > ...ant >> > >> > >
