On 06/05/2010, Paul Querna <p...@querna.org> wrote: > On Thu, May 6, 2010 at 2:59 PM, sebb <seb...@gmail.com> wrote: > > On 06/05/2010, Paul Querna <p...@querna.org> wrote: > >> On Thu, May 6, 2010 at 2:24 PM, Paul Querna <p...@querna.org> wrote: > >> > On Thu, May 6, 2010 at 2:20 PM, sebb <seb...@gmail.com> wrote: > >> >> On 06/05/2010, Paul Querna <p...@querna.org> wrote: > >> >>> The Apache Libcloud project is currently voting on our second > release, > >> >>> 0.3.0. As required by Incubator policy, we need IPMC approval for > >> >>> this release. There is a concurrent release vote ongoing on > >> >>> <libcl...@incubator.apache.org>. > >> >>> > >> >>> The current (passing) RAT output can be seen at: > >> >>> <http://ci.apache.org/projects/libcloud/rat-output.txt> > >> >> > >> >> Which does not include many of the files in the release archive - e.g > >> >> none of the fixtures are included. > >> >> > >> >> I checked a few of these, and none of the json or XML files had AL > headers. > >> > > >> > These are in the .ratignore, because all of these are test fixtures, > >> > returning raw data from API providers for the test cases, so adding AL > >> > headers would invalidate the tests. > >> > > > > Is that true of *all* the fixture files? > > > Yes. They are all used by our MockHTTPLayer as raw response bodies -- > adding license blocks to them would make them different from what the > providers return. >
I've just tried adding AL headers to some of the XML fixtures files. Added to all the ec2 and opennebula xml files. The test still runs without an error. Either these files can have AL headers, or they are not used by the test cases. > >> To be clear, the tarball doesn't include the .ratignore file, so I'm > >> not sure running RAT over the generated tarballs will produce the > >> expected results. > >> > >> The best test would be to run > >> svn checkout > https://svn.apache.org/repos/asf/incubator/libcloud/tags/0.3.0 > >> libcloud-0.3.0 > >> > >> and run RAT from there. > >> > >> As documented in HACKING, the actual release tarballs are generated by > >> dist/release.sh, which doesn't include developer releated files like > >> .ratignore and .gitignore. > > > > There is still the problem of the incorrect NOTICE file. > > > I've fixed it in trunk: > http://svn.apache.org/repos/asf/incubator/libcloud/trunk/NOTICE > > With just the NOTICE issue, do you maintain a -1 vote? > > > > Also, I could not run the test suite: > > > >> python setup.py test > > running test > > Traceback (most recent call last): > > File "setup.py", line 98, in <module> > > 'Topic :: Software Development :: Libraries :: Python Modules' > > File "c:\python26\lib\distutils\core.py", line 152, in setup > > dist.run_commands() > > File "c:\python26\lib\distutils\dist.py", line 975, in run_commands > > self.run_command(cmd) > > File "c:\python26\lib\distutils\dist.py", line 995, in run_command > > cmd_obj.run() > > File "setup.py", line 45, in run > > tests = TestLoader().loadTestsFromNames(testfiles) > > File "c:\python26\lib\unittest.py", line 613, in loadTestsFromNames > > suites = [self.loadTestsFromName(name, module) for name in names] > > File "c:\python26\lib\unittest.py", line 576, in loadTestsFromName > > module = __import__('.'.join(parts_copy)) > > File "D:\ReleaseCheck\apache-libcloud-0.3.0\test\__init__.py", line > > 19, in <module> > > from libcloud.base import Node, NodeImage, NodeLocation > > File "D:\ReleaseCheck\apache-libcloud-0.3.0\libcloud\base.py", line > > 21, in <module> > > from zope import interface > > ImportError: No module named zope > > > libcloud depends on zope interface for defining and validating that > the python APIs are consistent between drivers: > http://pypi.python.org/pypi/zope.interface > easy_install zope.interface > > In addition, to my knowledge, no one actually tests or run libcloud on > windows, so any bug reports there would be great to add to JIRA, > > > Thanks, > > Paul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
