First of all thanks for the thorough review.
These are all optional dependencies and we don't package them. All our
code is written against the JDBC api, we don't need any driver
implementation for compilation. So I don't see the problem.
It seems we forgot to comment the mysql dependency in the codegen
which is the only place and it will cause the mysql driver to be
downloaded to your local maven repository when using it... is this
blocking for the release? (just fixed this in trunk)
Cheers,
Francis
On Sun, May 9, 2010 at 5:05 AM, Thomas Fischer <fisc...@seitenbau.net> wrote:
> rat report looks good
> signatures are ok
> maven jars are the same as in other distribution - good work !
> source builds
>
> However, I found various dependencies which are not compatible with the ASF
> license. These dependencies are NOT included in any distribution file.
> However, as I read [1] ("which licenses are acceptable for use with an
> Apache product"), dependencies must also comply with the 3rd party license
> policy. Please correct me if I'm wrong.
>
> mysql-connector-java is released under GPL, according to [2] . GPL
> dependencies are not ok according to [3]
>
> Not sure about hsqldb. It is not explicitly listed on [4], but as it is a
> MIT style license, I presume it's ok, but IANAL.
>
> The h2database is dual-licensed under a modified mpl and epl. Both need to
> be appropriately labeled, see [5]. I do not see such prominent labelling in
> the distribution.
>
> The postgresql license is also not listed in [4]. I presume it's ok, but
> IANAL.
>
> So I'm afraid this is a -1.
>
> Thomas
>
> P.S. Sorry for waiting so long with the review, but I have been very busy
> personally and now finally managed to find a time slice for this.
>
> [1] http://www.apache.org/legal/3party.html
> [2] http://dev.mysql.com/downloads/connector/j/
> [3] http://www.apache.org/legal/resolved.html#category-x
> [4] http://www.apache.org/legal/resolved.html#category-a
> [5] http://www.apache.org/legal/resolved.html#category-b
>
>
>> Francis De Brabandere wrote:
>>> re: [VOTE] Release Apache Empire-db 2.0.6-incubating (rc4)
>>>
>>> Hi,
>>>
>>> We have just prepared the fourth 2.0.6-incubating release candidate
>>> and we are now looking for approval of the IPMC to publish the release.
>>>
>>> PMC vote thread:
>>> http://mail-archives.apache.org/mod_mbox/incubator-empire-db-
>>> dev/201004.mbox/browser
>>> We already have one binding vote.
>>>
>>> These are the major change from our previous 2.0.5-incubating release:
>>>
>>> - Code-Generator allows generation of Data Model code files for
>>> existing databases
>>> - Maven plugin for DB-Code-Generator
>>> - New example to demonstrate interoperability between Empire-db and
>>> Spring
>>> - Provided jars are now OSGi compatible
>>>
>>> Changelog:
>>> http://svn.apache.org/viewvc/incubator/empire-db/tags/apache-empire-db-
>>> 2.0.6-incubating-rc4/CHANGELOG.txt?view=co
>>>
>>> Subversion tag:
>>> https://svn.apache.org/repos/asf/incubator/empire-db/tags/apache-
>>> empire-db-2.0.6-incubating-rc4
>>>
>>> Maven staging repository:
>>> https://repository.apache.org/content/repositories/orgapacheempire-db-
>>> 020/
>>>
>>> Distribution files are located here
>>> http://people.apache.org/~francisdb/empire-db/
>>>
>>> Rat report for the tag is available here:
>>> http://people.apache.org/~francisdb/empire-db/rat.txt
>>>
>>> Vote open for 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
