Hi Justin,

On Sat, Feb 7, 2015 at 8:10 PM, Justin Mclean <[email protected]> wrote:
> Hi,
>
> +1 binding
>
> - hashes and signature correct
> - LICENCE and NOTICE correct (except notice year is wrong)
> - DISCLAIMER exists
> - incubating in source package name
> - all source file have Apache header
> - no unexpected binary files in release
> - can compile from source
>
> Minor issues:
> - you may want to consider adding apache to the artefact name
> - year in NOTICE incorrect (2014)
> - year in pox.xml incorrect (2013)

Thanks for the suggestion. Will fix them in next release.

Terence

>
> Thanks,
> Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to