+1 binding On Tue, Apr 21, 2015 at 10:03 PM Justin Mclean <[email protected]> wrote:
> Hi, > > (sending again as sent from wrong address first time) > > +1 binding > > For the source release I checked: > - incubating in artifact name > - signatures and hashes good > - LICENSE and NOTICE ok > - All source files have Apache headers > - No unexpected binary files > - Still can’t compile from source but it tells me I have wrong java version > - most of the issues raised from the last release have been fixed > > Minor issues - please fix for next release. > - No need to add normalise.css to NOTICE as it is MIT licensed > (Permissive licenses only need to be added to LICENSE in most cases - the > main exceptions being Apache licensed software with NOTICE files and files > that have had their copyright removed). The copyright notice here should go > into LICENSE. > - I'm still not sure of the reason why some of the artefacts are named > gremlin rather than tinkerpop > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
