Thanks everyone for the feedback, we'll fix the rat for the next release. There seem to be some random test failures, we are investigating the causes.
-- Gianmarco On Fri, Sep 23, 2016 at 2:04 PM, Stian Soiland-Reyes <st...@apache.org> wrote: > My vote: 0 (non-binding) > > +1 tag/commit > +1 git vs source zip > +1 No binaries > 0 mvn install fails in test > 0 Apache rat is not happy > 0 dist includes a _remote.repositories file - this should be removed > +1 LICENSE DISCLAIMER NOTICE > > I'm afraid it's not a positive vote from me because the build fails in > test - and the README told me to do "mvn package" (A workaround here > could be to use -DskipTests=true - but I don't know why the test > fails) > > > Apache rat complains about: > !????? CONTRIBUTING.md > !????? .travis.yml > !????? bin/samza-kryo > > These should be added to pom.xml's apache-rat configuration to be > ignored. None of them are worthy of a license header I think. > > > Your vote email didn't say the hash of the source distro, it is (sha1) > cab5ace6bfff3b70f883db61578fbda847f0fd66 > samoa-0.4.0-incubating-source-release.zip > > (which matches *.sha1 on dist) > > > > > > Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.411 > sec <<< FAILURE! - in > org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest > testStartSendingEvents(org.apache.samoa.topology.impl. > SimpleEntranceProcessingItemTest) > Time elapsed: 0.313 sec <<< ERROR! > java.lang.IllegalStateException: Missing invocation to mocked type at > this point; please make sure there is an associated mock field or mock > parameter in scope > at org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTe > st$4.<init>(SimpleEntranceProcessingItemTest.java:159) > at org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTe > st.testStartSendingEvents(SimpleEntranceProcessingItemTest.java:155) > > [INFO] Apache SAMOA ....................................... SUCCESS [ > 4.748 s] > [INFO] samoa-instances .................................... SUCCESS [ > 3.676 s] > [INFO] samoa-api .......................................... SUCCESS [ > 22.050 s] > [INFO] samoa-test ......................................... SUCCESS [ > 2.149 s] > [INFO] samoa-local ........................................ FAILURE [ > 49.418 s] > > using > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 2015-11-10T16:41:47+00:00) > Maven home: /home/stain/software/maven > Java version: 1.8.0_91, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-38-generic", arch: "amd64", family: > "unix" > > On 19 September 2016 at 14:50, Nicolas Kourtellis <nkourtel...@gmail.com> > wrote: > > Hi all, > > > > Our new release has been voted from the Apache SAMOA team and we are > > opening the vote to the incubator email list for testing. > > > > Please vote on releasing the following release candidate as Apache > > SAMOA (incubating) > > version 0.4.0. This release will be the second release for SAMOA in the > > incubator. > > > > ------------------------------------------------------------- > > The commit to be voted on is in the branch "releases/0.4.0-incubating" > > (commit fc39238dd7d3674c069a8142312da8c1812bc907): > > https://git1-us-west.apache.org/repos/asf/incubator-samoa/ > > repo?p=incubator-samoa.git;a=commit;h=fc39238dd7d3674c069a8142312da8 > > c1812bc907 > > > > Tag v0.4.0-incubating: > > https://git1-us-west.apache.org/repos/asf/incubator-samoa/ > > repo?p=incubator-samoa.git;a=tag;h=aa5bd941ccbed1aabb46b8119049ac > 1bb293c3a2 > > > > Release artifacts are signed with the following key: > > *https://people.apache.org/keys/committer/nkourtellis.asc > > <https://people.apache.org/keys/committer/nkourtellis.asc>* > > > > The staging repository for this release can be found at: > > https://repository.apache.org/content/repositories/staging/ > > org/apache/samoa/samoa/0.4.0-incubating/ > > > > The developer's version artifacts: > > https://dist.apache.org/repos/dist/dev/incubator/samoa/0.4. > 0-incubating-rc1/ > > > > ------------------------------------------------------------- > > > > Please vote on releasing this package as Apache SAMOA 0.4.0 (incubating). > > > > The vote is open for the next 72 hours and passes if a majority of at > least > > three +1 PPMC votes are cast. > > > > [ ] +1 Release this package as Apache SAMOA 0.4.0 (incubating) > > [ ] -1 Do not release this package because ... > > > > I'm +1 on the release. > > > > Cheers, > > > > Nicolas > > > > > > > > -- > > Nicolas Kourtellis > > > > -- > Stian Soiland-Reyes > http://orcid.org/0000-0001-9842-9718 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
