+1 binding, but there's a few things that need fixing for the next release.

Missing source release at [1] and this source release(?) at [2] contains jars 
not source. So assuming [3] is the source release - can you confirm this please.

I checked:
- name contains incubating
- hashes good, signatures OK
- LICENSE is likely to be missing a few things (see below)
- NOTICE is good
- All source files have ASF headers
- No unexpected binaries in source release
- Can compile from source

The LICENSE may be missing these licenses:
- These files[5][6][7] are copyright Mark Pilgrim(?), do you have permission to 
use them? Looks like it may of come from here? [8] IF so I think that is 
covered by a BSD license [9]?
- Do you have permission to distribute this file [10]? From google reverse 
image search it looks like it may come from Dojo Toolkit which is BSD licensed 

Looks like this file [4] may need updating (copyright IBM all over the place).

The binary LICENSE and NOTICE file are missing many things [12]. See also the 
guiding principle [13]. I can see code from other projects including Jetty, 
Geronimo, mail classes from Sun, ASM core, Apache commons, Jena, Xerces, etc 
etc. This is likely to require changes to both the LICENSE and NOTICE files. 
Please fix for the next release.

Also please consider signing the release with an apache email address.


4. ./juneau-core/src/main/java/org/apache/juneau/dto/atom/package.html
5. ./juneau-6.0.0-incubating/juneau-core/src/test/resources/dto/atom/test1.xml
6. ./juneau-6.0.0-incubating/juneau-core/src/test/resources/dto/atom/test2.xml
7. ./juneau-6.0.0-incubating/juneau-core/src/test/resources/dto/atom/test3.xml
8. https://www.ietf.org/rfc/rfc4287.txt
9. https://trustee.ietf.org/copyright-faq.html (see section 3.1)
11. https://dojotoolkit.org/license.html
12. http://www.apache.org/dev/licensing-howto.html#binary
13. http://www.apache.org/dev/licensing-howto.html#guiding-principle

To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to