Thanks for reviewing. I'll look into the things you mentioned. Josh Elser <els...@apache.org>于2017年6月7日 周三下午11:24写道：
> +1 (binding) > > * Make sure https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS > exists at https://dist.apache.org/repos/dist/release/incubator/weex/KEYS. > * Would recommend sha512 instead of sha1 for the future. > * Ran into an issue with node-7.7.4, upgrade to 8 seems to have gotten > past that. > * After that, I'm running into an issue with the build failing due to a > missing ".wwprc" file. Not sure what to do with that.. Looks like your > build instructions/script could use a refresh :) > * L&N look ok at a glance. xsums/sigs are good. > > On 6/5/17 5:27 AM, sospartan wrote: > > Hi all, > > > > I'm calling a vote for Weex-incubating 0.12.0-RC5 release. > > The changes fix problems pointed out by John D. Ament and Justin Mclean > in > > RC4 voting thread[1]. > > Thanks to these guys. And thanks to people who vote +1 too. Hope this RC > > would finally passed. > > > > The PPMC vote for this release has passed: > > * > https://lists.apache.org/thread.html/866a707deea418ff5374d38783f5591d0cda6fa09515766fec101d3e@%3Cdev.weex.apache.org%3E > > < > https://lists.apache.org/thread.html/866a707deea418ff5374d38783f5591d0cda6fa09515766fec101d3e@%3Cdev.weex.apache.org%3E > >* > > > > The tag to be voted upon: > > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git > > ;a=shortlog;h=refs/tags/0.12.0-rc5 > > > > The commit hash: > > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=commit;h= > > dcf9a83360b4403ffbdbfb3e168a68d1ff7a2b38 > > > > The source tarball can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/weex/0.12.0-incubating/RC5/ > > > > The fingerprint of key to sign release artifacts: > > 97B9 6598 A6A3 B63C 53BD 77E9 44C5 2286 22B9 7784 > > > > Release artifacts are signed with the following key: > > https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS > > > > Release note about this version: > > https://issues.apache.org/jira/browse/WEEX-26 > > > > This vote will remain open for at least 72 hours. > > Please vote on releasing this RC. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > > > 1. > > > https://lists.apache.org/thread.html/9e9308203feb3e9651644e7bef6578a50cf21a4a0513bd6175e1fb53@%3Cgeneral.incubator.apache.org%3E > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Best Regards! sospartan http://weex.apache.org/ <https://weex-project.io/>
