John - we'd appreciate your vote so that we can proceed with the release. Thanks -Andreas.
On Wed, Sep 20, 2017 at 11:18 PM, Andreas Neumann <[email protected]> wrote: > John - we will fix this as one of the first things after release, and will > appreciate your feedback early-on, so that this is not an issue again. > Thanks -Andreas > > On Wed, Sep 20, 2017 at 7:56 PM, John D. Ament <[email protected]> > wrote: > >> I'm fine with giving a +1 assuming the NOTICE issue is fixed for next >> release. Please feel free to ping me if you want a review of the NOTICE >> contents before release. >> >> John >> >> On Wed, Sep 20, 2017 at 10:34 PM James Taylor <[email protected]> >> wrote: >> >> > John - thanks for the review. If things look acceptable now, would you >> be >> > willing to cast a vote? >> > >> > Anyone else? >> > >> > Thanks, >> > James >> > >> > On Wed, Sep 20, 2017 at 11:58 AM Gokul Gunasekaran <[email protected]> >> > wrote: >> > >> > > Thanks, John! Is there anything else that we can do to address >> > > concerns/issues regarding the release candidate? >> > > >> > > On Wed, Sep 20, 2017 at 11:26 AM, John D. Ament < >> [email protected]> >> > > wrote: >> > > >> > > > On Wed, Sep 20, 2017 at 2:21 PM Gokul Gunasekaran <[email protected] >> > >> > > > wrote: >> > > > >> > > > > Hi John, >> > > > > >> > > > > Regarding your comment, >> > > > > >> > > > > > > I don't see any of this text in your NOTICE file. Likewise, I >> > > don't >> > > > > see >> > > > > > > where the contents of the NOTICE are coming from >> > > > > > > >> > > > > >> > > > > The LICENSE and NOTICE files that, are in the distribution, are >> > present >> > > > in >> > > > > the tephra-distribution directory (named LICENSE_BINARY, >> > > NOTICE_BINARY). >> > > > > Please let us know if they should be placed in a different >> location >> > > and I >> > > > > can address the same in the JIRA mentioned below. >> > > > > >> > > > >> > > > It's fine to keep the binary copy of the NOTICE and LICENSE in your >> > > source >> > > > release. Clearly marking them this way works fine. >> > > > >> > > > >> > > > > >> > > > > Also, let us know if you think we can proceed with the release. I >> > have >> > > > > opened JIRA (https://issues.apache.org/jira/browse/TEPHRA-265) to >> > > > address >> > > > > the issue with the NOTICE file. >> > > > > >> > > > > Thanks, >> > > > > Gokul >> > > > > >> > > > > On Mon, Sep 18, 2017 at 7:24 PM, Andreas Neumann <[email protected] >> > >> > > > wrote: >> > > > > >> > > > > > John, is this a show stopper, or would it be ok if we address >> that >> > > Jira >> > > > > in >> > > > > > the next release? >> > > > > > >> > > > > > On Mon, Sep 18, 2017 at 6:47 PM, Gokul Gunasekaran < >> > [email protected] >> > > > >> > > > > > wrote: >> > > > > > >> > > > > > > Thanks so much for the explanation, John! Really appreciate >> it. >> > > > > > > >> > > > > > > I have opened a JIRA (https://issues.apache.org/ >> > > > jira/browse/TEPHRA-265 >> > > > > ) >> > > > > > to >> > > > > > > fix this issue. Please let me know if you have any questions >> or >> > > > > comments >> > > > > > > about the same. >> > > > > > > >> > > > > > > On Mon, Sep 18, 2017 at 6:30 PM, John D. Ament < >> > > > [email protected]> >> > > > > > > wrote: >> > > > > > > >> > > > > > > > Gokul, >> > > > > > > > >> > > > > > > > On Mon, Sep 18, 2017 at 9:14 PM Gokul Gunasekaran < >> > > > [email protected]> >> > > > > > > > wrote: >> > > > > > > > >> > > > > > > > > Hi John, >> > > > > > > > > >> > > > > > > > > Thanks for the review of the release candidate. >> > > > > > > > > >> > > > > > > > > - NOTICE file for Guice: The NOTICE_BINARY file under >> > > > > > > > tephra-distribution, >> > > > > > > > > contains the notice for Guice. Please let us how we can >> fix >> > it >> > > > and >> > > > > we >> > > > > > > > will >> > > > > > > > > create a JIRA to fix this issue. We had followed the >> example >> > of >> > > > > > > including >> > > > > > > > > libraries that has Apache License 2.0 in NOTICE, similar >> to >> > the >> > > > > > > Fineract >> > > > > > > > > project. >> > > > > > > > > >> > > > > > > > >> > > > > > > > Do you have an example? This is what your NOTICE file says: >> > > > > > > > >> > > > > > > > Apache Tephra includes Guice v3.0 and Guice Assisted Inject >> > v3.0. >> > > > > > Tephra >> > > > > > > > elects to include this software in this distribution under >> the >> > > > Apache >> > > > > > > > License. >> > > > > > > > You can obtain a copy of the License at: >> > > > > > > > http://apache.org/licenses/LICENSE-2.0 >> > > > > > > > >> > > > > > > > NOTICE files are meant to copy verbatim the existing NOTICE >> > file. >> > > > > This >> > > > > > > is >> > > > > > > > what I see in the Guice 3 NOTICE files: >> > > > > > > > >> > > > > > > > Google Guice - Core Library >> > > > > > > > Copyright 2006-2011 Google, Inc. >> > > > > > > > >> > > > > > > > This product includes software developed at >> > > > > > > > The Apache Software Foundation (http://www.apache.org/). >> > > > > > > > >> > > > > > > > >> > > > > > > > Google Guice - Extensions - AssistedInject >> > > > > > > > Copyright 2006-2011 Google, Inc. >> > > > > > > > >> > > > > > > > This product includes software developed at >> > > > > > > > The Apache Software Foundation (http://www.apache.org/). >> > > > > > > > >> > > > > > > > I don't see any of this text in your NOTICE file. >> Likewise, I >> > > > don't >> > > > > > see >> > > > > > > > where the contents of the NOTICE are coming from >> > > > > > > > >> > > > > > > > RE Fineract. The last release I have of theres locally is >> > 0.6.0 >> > > > and >> > > > > it >> > > > > > > > does not have these issues, so not sure where you're getting >> > this >> > > > > from. >> > > > > > > > >> > > > > > > > John >> > > > > > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > - LGPL License: The Release Candidate - 2 doesn't include >> the >> > > > LGPL >> > > > > > > > license >> > > > > > > > > at all. Do you see LGPL license included anywhere (this >> might >> > > > have >> > > > > > been >> > > > > > > > > present in the Release Candidate - 1 which was fixed in >> > Release >> > > > > > > > Candidate - >> > > > > > > > > 2)? >> > > > > > > > > >> > > > > > > > > Thanks, >> > > > > > > > > Gokul >> > > > > > > > > >> > > > > > > > > On Mon, Sep 18, 2017 at 5:08 PM, John D. Ament < >> > > > > > [email protected]> >> > > > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > > Hi, >> > > > > > > > > > >> > > > > > > > > > I'm inclined to vote -1 unless someone convinces me >> > > otherwise. >> > > > > > > > > > >> > > > > > > > > > TEPHRA-231 was created to address issues identified, >> > however >> > > it >> > > > > > > doesn't >> > > > > > > > > > seem to have been solved properly. >> > > > > > > > > > >> > > > > > > > > > - The changes to the NOTICE file don't match the NOTICE >> > file >> > > > for >> > > > > > > Guice. >> > > > > > > > > > There is no need to declare the license usage for single >> > > > licensed >> > > > > > > code. >> > > > > > > > > > - You added the LGPL license. You cannot include LGPL >> > > > binaries. >> > > > > > > > > However, >> > > > > > > > > > I can't find the binaries so it should probably just be >> > > > omitted. >> > > > > > > > > > >> > > > > > > > > > Other things look fine. >> > > > > > > > > > >> > > > > > > > > > John >> > > > > > > > > > >> > > > > > > > > > On Mon, Sep 18, 2017 at 1:13 PM Andreas Neumann < >> > > > [email protected] >> > > > > > >> > > > > > > > wrote: >> > > > > > > > > > >> > > > > > > > > > > Hi all, >> > > > > > > > > > > >> > > > > > > > > > > This is a call for a vote on releasing Apache Tephra >> > > > > > > > 0.13.0-incubating, >> > > > > > > > > > > release candidate 2. This is the sixth release of >> Tephra. >> > > > > > > > > > > >> > > > > > > > > > > The Apache Tephra community has voted and approved the >> > > > release. >> > > > > > > > > > > >> > > > > > > > > > > Vote thread: >> > > > > > > > > > > >> > > http://mail-archives.apache.org/mod_mbox/incubator-tephra-de >> > > > > > > > > > v/201709.mbox/% >> > > > > > > > > > > 3CCANpmDOfN7MPHYjKt-PqNd3yY1Kt >> gyNn6L1ANT63xxPEdSsXQuA% >> > > > > > > > 40mail.gmail.com >> > > > > > > > > > %3E >> > > > > > > > > > > < >> > > http://mail-archives.apache.org/mod_mbox/incubator-tephra-d >> > > > > > > > > > >> > ev/201709.mbox/%3CCANpmDOfN7MPHYjKt-PqNd3yY1KtgyNn6L1ANT63xx >> > > > > > > > > > PEdSsXQuA%40mail.gmail.com%3E> >> > > > > > > > > > > >> > > > > > > > > > > Result thread: >> > > > > > > > > > > >> > > http://mail-archives.apache.org/mod_mbox/incubator-tephra-de >> > > > > > > > > > v/201709.mbox/% >> > > > > > > > > > > >> > > 3CCANpmDOe8T70zU4h%2BgknSJ%2B%3DTOAkUw9praf46GTtuz-5Cr2-7jA% >> > > > > > > > > > > 40mail.gmail.com%3E >> > > > > > > > > > > >> > > > > > > > > > > The source tarball, including signatures, digests, >> etc. >> > can >> > > > be >> > > > > > > found >> > > > > > > > > at: >> > > > > > > > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0.13 >> > > > > > > > > > > .0-incubating-rc2/src >> > > > > > > > > > > >> > > > > > > > > > > The tag to be voted upon is v0.13.0-incubating: >> > > > > > > > > > > >> > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.g >> > > > > > > > > > > it;a=shortlog;h=refs/tags/v0.13.0-incubating >> > > > > > > > > > > >> > > > > > > > > > > The release hash is 37467ce63934aca86f84eb61493733 >> > > > bb470450d7: >> > > > > > > > > > > >> > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.g >> > > > > > > > > > > it;a=commit;h=37467ce63934aca8 >> 6f84eb61493733bb470450d7 >> > > > > > > > > > > >> > > > > > > > > > > The Nexus Staging URL: >> > > > > > > > > > > >> > > > > > > > > https://repository.apache.org/content/repositories/ >> > > > > > > orgapachetephra-1010 >> > > > > > > > > > > >> > > > > > > > > > > Release artifacts are signed with the following key: >> > > > > > > > > > > http://people.apache.org/keys/committer/anew >> > > > > > > > > > > >> > > > > > > > > > > KEYS file available: >> > > > > > > > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/tephra/KEYS >> > > > > > > > > > > >> > > > > > > > > > > For information about the contents of this release, >> see: >> > > > > > > > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0.13 >> > > > > > > > > > > .0-incubating-rc2/CHANGES.txt >> > > > > > > > > > > >> > > > > > > > > > > Please vote on releasing this package as Apache Tephra >> > > > > > > > > 0.13.0-incubating >> > > > > > > > > > > >> > > > > > > > > > > The vote will be open for 72 hours. >> > > > > > > > > > > >> > > > > > > > > > > [ ] +1 Release this package as Apache Tephra >> > > > 0.13.0-incubating >> > > > > > > > > > > [ ] +0 no opinion >> > > > > > > > > > > [ ] -1 Do not release this package because ... >> > > > > > > > > > > >> > > > > > > > > > > Thanks, >> > > > > > > > > > > Andreas >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
