Hi， I found the License files (LICENSE-jafama.txt and LICENSE-smile) are both standate ASLV2, they are the same with LICENSE file. Do we still need to ship them separately? Can we just using the LICENSE file directly?
Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Sat, Mar 3, 2018 at 11:40 AM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes correct > - disclaimer exists > - LICENSE and NOTICE good > - all source files have ASF headers > - no unexpected binary files > > I noticed a minor issue is that LICENSE is missing the MIT license for > this file [1] > > Thanks, > Justin > > 1. hivemall-0.5.0-incubating/src/site/resources/css/font-awesome.css > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
