Shuang, Apologies for my late reply.
Only issue I see is the inclusion of compiled code in the source release. It's generally expected to not have class files, jars in the source release. We have good faith on what is included, but no way to confirm. Also, since you now include RAT in the distribution, there's no NOTICE or LICENSE updates required? (I haven't checked). Is it possible for you just to provide instructions on how to run rat in the project, rather than creating a wrapper? John On 2018/05/17 11:42:22, SHUANG SU <sushuang0...@gmail.com> wrote: > I am pleased to be calling this vote for the release of Apache ECharts > 4.1.0.rc3. > > Apache ECharts community has voted and approved the release. > > Vote thread: > https://lists.apache.org/thread.html/67dffef28ecffd66689ac991ca027c0868d734629949d958e7b12dd3@%3Cdev.echarts.apache.org%3E > > Results thread: > https://lists.apache.org/thread.html/3a6e627a7e07d5de0856296d44bb408e17ee6795cc74ef190a7a5d23@%3Cdev.echarts.apache.org%3E > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc3/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > A tagged git repository is available for review at: > https://github.com/apache/incubator-echarts/releases/tag/4.1.0.rc3 > > The Git commit for this release is: > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=f98eb21 > > The Release Note is available in: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc3/RELEASE_NOTE.txt > > Some shell commands for validating the release: > > ```shell > # Download the release: > curl > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc3/apache-echarts-4.1.0.rc3-incubating.zip > -o apache-echarts-4.1.0.rc3-incubating.zip > unzip apache-echarts-4.1.0.rc3-incubating.zip -d > apache-echarts-4.1.0.rc3-incubating > /dev/null > > # Rebuild the project: > cd "apache-echarts-4.1.0.rc3-incubating" && npm install && cd .. > node "apache-echarts-4.1.0.rc3-incubating/build/build.js" --release > # (See help: `node "apache-echarts-4.1.0.rc3-incubating/build/build.js" > --help`) > > # Run Apache Rat: > java -jar "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" | less > # (See help: `java -jar > "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" --help`) > ``` > > > Please vote on releasing this package as: > Apache ECharts 4.1.0.rc3 > > This vote will be open until "2018-05-20T12:33:24.955Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > > ------------------------------ > Su Shuang (100pah) > ------------------------------ > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
