Hi Matteo, Having 2 different license headers for a source files is a bit strange, the user would be confused what license the file actually uses. The 3Clause-BSD license allows us to modify and redistribute in source form, but I'm not sure whether it's OK to re-license it to ASL.
On Fri, Jun 8, 2018 at 2:17 PM, Matteo Merli <matteo.me...@gmail.com> wrote: > Hi Yang, > > these files are not directly found in Protobuf, though their content is > derived from Protobuf code, though with several additions. These are > special adapters to have protobuf to interact directly with Netty ByteBuf > with zero-copy access. Based on an earlier discussion, the resolution was > to have both headers as well as a comment that says: > > /** > * This file is derived from Google ProcolBuffer CodedInputStream class > */ > > Matteo > > On Thu, Jun 7, 2018 at 7:22 PM Yang Bo <oaky...@gmail.com> wrote: > > > Hi, > > > > I checked the source release and found a minor issue: > > > > pulsar-common/src/main/java/org/apache/pulsar/common/util/ > protobuf/ByteBufCoded{Input,Output}Stream.java > > Those files are from google thus should not have ASF header in the source > > file. > > > > > > On Fri, Jun 8, 2018 at 9:51 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > > > +1 (repeated my +1 from dev@ votes) > > > > > > On Thu, Jun 7, 2018 at 11:29 AM Jai Asher <jai.ashe...@gmail.com> > wrote: > > > > > > > This is the second release candidate for Apache Pulsar, patch release > > > > version 1.22.1-incubating. > > > > > > > > It fixes the following issues: > > > > https://github.com/apache/incubator-pulsar/milestone/15?closed=1 > > > > > > > > *** Please download, test and vote on this release. This vote will > stay > > > > open for at least 72 hours *** > > > > > > > > Note that we are voting upon the source (tag), binaries are provided > > for > > > > convenience. > > > > > > > > Source and binary files: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/ > > > pulsar-1.22.1-incubating-candidate-2/ > > > > > > > > SHA-1 checksums: > > > > > > > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09 > > > > apache-pulsar-1.22.1-incubating-src.tar.gz > > > > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b > > > > apache-pulsar-1.22.1-incubating-bin.tar.gz > > > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1018/ > > > > > > > > The tag to be voted upon: > > > > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3 > > > fbfa627aca) > > > > > > > > https://github.com/apache/incubator-pulsar/releases/tag/ > > > v1.22.1-incubating-candidate-2 > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > > > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > > > > > > > Please download the source package, and follow the README to build > and > > > run > > > > the Pulsar standalone service. > > > > > > > > > > > > > > > -- > > Best Regards, > > Yang. > > > -- > Matteo Merli > <mme...@apache.org> > -- Best Regards, Yang.