+1 (carried over) On Sun, Jul 8, 2018 at 12:15 AM, Justin Mclean <jus...@classsoftware.com> wrote:
> Hi, > > +1 (binding) > > Sorry did this a while back but forgot to send > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is OK but could be improved > - NOTICE year needs updating > - no unexpected binary files > - all ASF source files have correct headers > - can compile from source > > For the license it would be nice to mention the version of the bundled > software and what the license is rather than just pointing to the license > file.Also the license files pointed to also contain multiple licenses which > is a little surprising, it’s may be better to put that info in the LICENSE > file an/or only have a single license per file. > > The source release also contains multiple archives [2][3][4][5] which > makes it harder to review, could these be expanded in the release? > > Thanks, > Justin > > 1. incubator-amaterasu-version-0.2.0-incubating-rc4 < > http://localhost:8081/repo/?mod=license&upload=2&item=6>/executor < > http://localhost:8081/repo/?mod=license&upload=2&item=54>/src < > http://localhost:8081/repo/?mod=license&upload=2&item=56>/main < > http://localhost:8081/repo/?mod=license&upload=2&item=57>/resources < > http://localhost:8081/repo/?mod=license&upload=2&item=58>/codegen.py > 2. incubator-amaterasu-version-0.2.0-incubating-rc4/executor/ > src/test/resources/py4j-0.10.4-src.zip > 3. incubator-amaterasu-version-0.2.0-incubating-rc4/executor/ > src/test/resources/py4j.tar.gz > 4. incubator-amaterasu-version-0.2.0-incubating-rc4/executor/ > src/test/resources/pyspark.tar.gz > 5. incubator-amaterasu-version-0.2.0-incubating-rc4/executor/ > src/test/resources/pyspark.zip
