Thanks Justin for the review and catching that, somehow I missed this sorry about that.
Regards, Serge... On Sat, Jul 14, 2018 at 9:49 AM Justin Mclean <justinmcl...@me.com> wrote: > > Hi, > > Sorry but it;’s -1 binding as the source release contains compile code. This > zip [1] contains compiled class files and a jar with compiled class files. > > Everything else is good I checked: > - incubating in name > - signatures and hash correct > - LICENSE is good > - NOTICE year (2016) needs updating > - All source file have ASF headers > - unexpected binaries inside zip file [1] > - can compile from source > > It a good idea to sign the artefacts with an apache email address. > > Thanks, > Justin > > 1. unomi-root-1.3.0-incubating/samples/trainingplugin.zip > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
