+1 I checked: - name - disclaimer - license and notice - build successfully - asf headers
Thanks, William On Wed, Nov 14, 2018 at 1:32 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE and NOTICE correct > - no unexpected binary files in releases > - all source files have ASF headers > - can compile from source > > One very tiny issue is that Gogo protobuf isn’t a BSD 3 clause license as > mention in LICENSE but actually BSD 2 clause license looking at it’s source > header. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
