> You may what to check what is tagged in SVN and what going into the release > as there a few minor differences (non source released).
Hi, Justin Could you provide more detail about the differences? SkyWalking has a release shell script[1], which excludes some files(such as git and submodule files) from github tag to build the source tar. Is this what you found? [1] https://github.com/apache/incubator-skywalking/blob/master/tools/releasing/create_source_release.sh#L63 Sheng Wu Apache SkyWalking, ShardingSphere, Zipkin From Wu Sheng 's phone. ------------------ Original ------------------ From: Justin Mclean <jus...@classsoftware.com> Date: Mon,Dec 24,2018 6:13 AM To: general <general@incubator.apache.org> Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 6.0.0-beta Hi, +1 binding. I checked: - incubating in name - DISCLAIMER exits - LICENSE and NOTICE are fine - Al source file have ASF headers - No unexpected binary files - Can compile from source You may what to check what is tagged in SVN and what going into the release as there a few minor differences (non source released). Thanks, Justin --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
