I vote with +0 (binding). Due to source build problems, I cannot vote +1 but not negative to other three +1 because an IPMC (Dave) was succeeded for src build and other checkpoints are green.
I checked the following points: - Are release files in correct location? Yes - Do release files have the word incubating in their name? Yes - Are the digital signature and hashes correct? Yes - Does DISCLAIMER file exist? Yes - Do LICENSE and NOTICE files exists? Yes - Is the LICENSE and NOTICE text correct? Yes (except issues pointed by Williem) - Is the NOTICE year correct? Yes - Un-included software dependencies are not mentioned in LICENSE or NOTICE? Not checked - License information is not mentioned in NOTICE? Yes Is there any 3rd party code contained inside the release? If so: - Does the software have a compatible license? Yes (checked LICENSE.txt) - Are all software licenses mentioned in LICENSE? Not checked - Is the full text of the licenses (or pointers to it) in LICENSE? Yes Is any of this code Apache licensed? Do they have NOTICE files? If so: - Have relevant parts of those NOTICE files been added to this NOTICE file? Yes - Do all source files have ASF headers? Rat check passed successfully https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release#3-verify-license-header - Do the contents of the release match with what's tagged in version control? Seems fine - Are there any unexpected binary files in the release? Rat check passed - Can you compile from source? Are the instruction clear? Failed to compile. Not sure users can build Doris from src. Instruction was clear. - Is the issue minor? Unsure - Could it possibly be fixed in the next release? Yes Thanks, Makoto 2019年1月12日(土) 2:12 Makoto Yui <m...@apache.org>: > With PARALLEL=1, the build fails as follows > > /usr/bin/../bin/g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift > -I./src > -I/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/installed/include > -Wall -Wextra -pedantic -g -O2 -std=c++11 -MT > src/generate/thrift-t_as3_generator.o -MD -MP -MF > src/generate/.deps/thrift-t_as3_generator.Tpo -c -o > src/generate/thrift-t_as3_generator.o `test -f > 'src/generate/t_as3_generator.cc' || echo > './'`src/generate/t_as3_generator.cc > > src/generate/t_as3_generator.cc: In member function 'void > t_as3_generator::generate_as3_struct(t_struct*, bool)': > > src/generate/t_as3_generator.cc:663:1: internal compiler error: Segmentation > fault > > } > > ^ > > Please submit a full bug report, > > with preprocessed source if appropriate. > > See <file:///usr/share/doc/gcc-5/README.Bugs> for instructions. > > Makefile:1066: recipe for target 'src/generate/thrift-t_as3_generator.o' > failed > > make[3]: *** [src/generate/thrift-t_as3_generator.o] Error 1 > > make[3]: Leaving directory > '/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/thrift-0.9.3/compiler/cpp' > > Makefile:588: recipe for target 'all' failed > > make[2]: *** [all] Error 2 > > make[2]: Leaving directory > '/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/thrift-0.9.3/compiler/cpp' > > Makefile:609: recipe for target 'all-recursive' failed > > make[1]: *** [all-recursive] Error 1 > > make[1]: Leaving directory > '/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/thrift-0.9.3' > > Makefile:530: recipe for target 'all' failed > > make: *** [all] Error 2 > > I'm not sure it's host memory issue. Host has enough memory left. > > BTW, the project page[1] should have disclaimer [2] of undergoing > incubation message. > [1] https://doris.incubator.apache.org/ > [2] https://incubator.apache.org/guides/branding.html#disclaimers > > Makoto > > 2019年1月11日(金) 17:07 Li,De(BDG) <l...@baidu.com>: > >> Hi Makoto, >> >> Thank you for your check. >> >> >> Why not cancel rc1 and create rc2 fixing license header issue that >> Willem >> >> pointed? >> >> It seems it's better to be fixed. >> >> Actually, we have fixed these issues in branch-0.9.0 (#471, #473) after >> Willem pointed. >> >> I’m afraid it will take everyone’s more time to check repeatedly and so >> I’m going to fix them in next version. >> >> >> It also seems that no one from IPMC succeeded to build distribution >> from src >> >> Indeed, the building is not good as we expect, but I noticed the main >> cause is that it can’t compile in OSX and it needs GCC 5.3.1+. >> But it seems Dave Meikle has succeeded to build in Ubuntu 18.04 and we >> have tested pass in CentOS and Ubuntu. >> We will continue to check and complete the building, also docker >> environment as you mentioned. >> >> Best Regards, >> Reed >> >> >> On 2019/1/11 上午2:23， "Makoto Yui" <yuin...@gmail.com> wrote: >> >> >Reed, >> > >> >Why not cancel rc1 and create rc2 fixing license header issue that Willem >> >pointed? >> >It seems it's better to be fixed. >> > >> >It also seems that no one from IPMC succeeded to build distribution from >> >src (no sure for Luke though). >> > >> >I got the following build error (which might be gcc-5 version issue): >> > >> >[ 57%] Building CXX object >> >> >projects/compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan_int >> >erceptors.cc.o >> > >> >> >/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/llvm-3.4. >> >2.src/projects/compiler-rt/lib/msan/msan_interceptors.cc: >> >In function 'void __msan::InitializeInterceptors()': >> > >> >> >/tmp/doris/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/llvm-3.4. >> >2.src/projects/compiler-rt/lib/msan/msan_interceptors.cc:1573:1: >> >internal >> >compiler error: Segmentation fault >> > >> > } >> > >> > ^ >> > >> >Please submit a full bug report, >> > >> >with preprocessed source if appropriate. >> > >> >See <file:///usr/share/doc/gcc-5/README.Bugs> for instructions. >> > >> >projects/compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/ >> build.ma >> >ke:134: >> >recipe for target >> >> >'projects/compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan_in >> >terceptors.cc.o' >> >failed >> > >> >I used ubuntu xenial on docker on OSX. >> >Software versions meets requirements (except Maven version) as seen in >> > >> >docker run ubuntu:xenial -it >> > >> > >> >$ apt-get install wget openjdk-8-jdk maven gcc-5 bzip2 python cmake zip >> >xz-utils patch byacc flex automake libtool g++ >> > >> > >> >root@d9e5b7017e7b:/tmp/doris/apache-doris-0.9.0.rc01-incubating-src# gcc >> >--version | head -1 >> > >> >gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 >> > >> > >> >root@d9e5b7017e7b:/tmp/doris/apache-doris-0.9.0.rc01-incubating-src# >> java >> >-version >> > >> >openjdk version "1.8.0_191" >> > >> >OpenJDK Runtime Environment (build >> >1.8.0_191-8u191-b12-0ubuntu0.16.04.1-b12) >> > >> >OpenJDK 64-Bit Server VM (build 25.191-b12, mixed mode) >> > >> > >> >root@d9e5b7017e7b:/tmp/doris/apache-doris-0.9.0.rc01-incubating-src# >> >python >> >--version >> > >> >Python 2.7.12 >> > >> > >> >root@d9e5b7017e7b:/tmp/doris/apache-doris-0.9.0.rc01-incubating-src# mvn >> >--version >> > >> >Apache Maven 3.3.9 >> > >> > >> >root@d9e5b7017e7b:/tmp/doris/apache-doris-0.9.0.rc01-incubating-src# >> cmake >> >--version >> > >> >cmake version 3.5.1 >> > >> > >> >$ ./build.sh >> > >> > >> > >> >Providing working Dockerfile would help to verify release by IPMC >> members. >> > >> >Thanks, >> >Makoto >> > >> >2019年1月10日(木) 15:51 Li,De(BDG) <l...@baidu.com>: >> >> >> >> Hi, >> >> >> >> Does anyone help us to check and vote？ >> >> Now we got two +1(binding). >> >> If needed we will cancel and call for next VOTE after fixed all issues >> >> which Willem and Justin mentioned. >> >> >> >> >> >> Best Regards, >> >> Reed >> >> >> >> On 2018/12/29 上午10:36， "Li,De(BDG)" <l...@baidu.com> wrote: >> >> >> >> >Hi Dave, >> >> > >> >> >I got it, thank you very much. Have a good trip. >> >> > >> >> >Best Regards, >> >> >Reed >> >> > >> >> >On 2018/12/28 下午10:49， "Dave Meikle" <dmei...@apache.org> wrote: >> >> > >> >> >>Hi Reed, >> >> >> >> >> >>I am traveling just now so away from the desktop that I tested the >> >>build >> >> >>on. I setup a clean virtual machine with Ubuntu 18.04 and tried from >> >> >>scratch, resulting in a perfect build. So must be something funky >> >>with >> >> >>my >> >> >>configuration back at base - it's been upgraded a few times, so sorry >> >for >> >> >>the hassle. >> >> >> >> >> >>(NOTE: I tried to build on a remote Ubuntu 18.10 at first getting a >> >> >>different error but it made sense due to the 3rd-party LLVM fails due >> >>to >> >> >>ustat depreciation in glibc). >> >> >> >> >> >>So +1 (binding) to the release. >> >> >> >> >> >>Cheers, >> >> >>Dave >> >> >> >> >> >>On Thu, 27 Dec 2018 at 12:13, Li,De(BDG) <l...@baidu.com> wrote: >> >> >> >> >> >>> Hi Dave, >> >> >>> >> >> >>> Thanks for your reply. >> >> >>> >> >> >>> The files of flat_map.h and json_to_pb.h are come from brpc, which >> >> >>>should >> >> >>> be installed in thirdparty/installed/include. >> >> >>> >> >> >>> >> >> >>> It seems brpc is not been compiled and installed successfully. >> >> >>> >> >> >>> Could you remove brpc and retry build as following command ? It >> will >> >> >>>help >> >> >>> us to know what happed. >> >> >>> >> >> >>> >> >> >>> $ cd >> >> >>> >> >> >> >> >>>>/home/dmeikle/Development/Apache/incubator/release-review/apache-doris- >> >>>>0 >> >> >>>. >> >> >>>9. >> >> >>> 0.rc01-incubating-src >> >> >>> $ rm -f thirdparty/installed/lib/librdkafka.a >> >> >>> $ rm -fr thirdparty/src/brpc-0.9.0* >> >> >>> $ sh build.sh >> >> >>> >> >> >>> Regards, >> >> >>> Reed >> >> >>> >> >> >>> On 2018/12/27 下午6:33， "David Meikle" <loo...@gmail.com> wrote: >> >> >>> >> >> >>> >Hi Reed, >> >> >>> > >> >> >>> >> On 27 Dec 2018, at 03:00, Li,De(BDG) <l...@baidu.com> wrote: >> >> >>> >> >> >> >>> >> Thanks to David, could you provide the detail for failure, >> >actually, >> >> >>>we >> >> >>> >> expect building is OK if following tools installed on Ubuntu. >> >> >>> >> >> >> >>> >> GCC 5.3.1+, Oracle JDK 1.8+, Python 2.7+, Apache Maven 3.5+, >> >>CMake >> >> >>> >>3.4.3+ >> >> >>> >> >> >> >>> >> >> >> >>> >> Best Regards, >> >> >>> >> Reed >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> >I get the following errors: >> >> >>> > >> >> >>> >-- CLANG_COMPATIBLE_FLAGS: -I/usr/include/c++/7 >> >> >>> >-I/usr/include/x86_64-linux-gnu/c++/7 >> -I/usr/include/c++/7/backward >> >> >>> >-I/usr/lib/gcc/x86_64-linux-gnu/7/include -I/usr/local/include >> >> >>> >-I/usr/lib/gcc/x86_64-linux-gnu/7/include-fixed >> >> >>> >-I/usr/include/x86_64-linux-gnu -I/usr/include >> >> >>> >-- Configuring done >> >> >>> >-- Generating done >> >> >>> >-- Build files have been written to: >> >> >>> >> >> >> >> >>>>>/home/dmeikle/Development/Apache/incubator/release-review/apache-doris >> >>>>>- >> >> >>>>0 >> >> >>>>.9 >> >> >>> >.0.rc01-incubating-src/be/build >> >> >>> >[ 1%] Built target gen_ir_descriptions >> >> >>> >[ 2%] Built target Udf >> >> >>> >[ 3%] Built target Common >> >> >>> >[ 14%] Built target Util >> >> >>> >[ 23%] Built target Exprs >> >> >>> >[ 32%] Built target Gutil >> >> >>> >[ 46%] Built target DorisGen >> >> >>> >[ 48%] Built target Agent >> >> >>> >[ 48%] Building CXX object >> >> >>> >src/http/CMakeFiles/Webserver.dir/ev_http_server.cpp.o >> >> >>> >[ 49%] Building CXX object >> >> >>> >src/olap/CMakeFiles/Olap.dir/olap_header_manager.cpp.o >> >> >>> >In file included from >> >> >>> >> >> >> >> >>>>>/home/dmeikle/Development/Apache/incubator/release-review/apache-doris >> >>>>>- >> >> >>>>0 >> >> >>>>.9 >> >> >>> >.0.rc01-incubating-src/be/src/http/ev_http_server.cpp:31:0: >> >> >>> >> >> >> >> >>>>>/home/dmeikle/Development/Apache/incubator/release-review/apache-doris >> >>>>>- >> >> >>>>0 >> >> >>>>.9 >> >> >>> >.0.rc01-incubating-src/be/src/service/brpc.h:50:10: fatal error: >> >> >>> >butil/containers/flat_map.h: No such file or directory >> >> >>> > #include <butil/containers/flat_map.h> >> >> >>> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> >>> >compilation terminated. >> >> >>> >src/http/CMakeFiles/Webserver.dir/build.make:350: recipe for >> target >> >> >>> >'src/http/CMakeFiles/Webserver.dir/ev_http_server.cpp.o' failed >> >> >>> >make[2]: *** >> >>[src/http/CMakeFiles/Webserver.dir/ev_http_server.cpp.o] >> >> >>> >Error 1 >> >> >>> >CMakeFiles/Makefile2:581: recipe for target >> >> >>> >'src/http/CMakeFiles/Webserver.dir/all' failed >> >> >>> >make[1]: *** [src/http/CMakeFiles/Webserver.dir/all] Error 2 >> >> >>> >make[1]: *** Waiting for unfinished jobs.... >> >> >>> >[ 49%] Building CXX object >> >> >>>src/olap/CMakeFiles/Olap.dir/olap_meta.cpp.o >> >> >>> >> >> >> >> >>>>>/home/dmeikle/Development/Apache/incubator/release-review/apache-doris >> >>>>>- >> >> >>>>0 >> >> >>>>.9 >> >> >>> >.0.rc01-incubating-src/be/src/olap/olap_header_manager.cpp:30:10: >> >> >>>fatal >> >> >>> >error: json2pb/json_to_pb.h: No such file or directory >> >> >>> > #include "json2pb/json_to_pb.h" >> >> >>> > ^~~~~~~~~~~~~~~~~~~~~~ >> >> >>> >compilation terminated. >> >> >>> >src/olap/CMakeFiles/Olap.dir/build.make:806: recipe for target >> >> >>> >'src/olap/CMakeFiles/Olap.dir/olap_header_manager.cpp.o' failed >> >> >>> >make[2]: *** >> >>[src/olap/CMakeFiles/Olap.dir/olap_header_manager.cpp.o] >> >> >>> >Error 1 >> >> >>> >make[2]: *** Waiting for unfinished jobs.... >> >> >>> >CMakeFiles/Makefile2:471: recipe for target >> >> >>> >'src/olap/CMakeFiles/Olap.dir/all' failed >> >> >>> >make[1]: *** [src/olap/CMakeFiles/Olap.dir/all] Error 2 >> >> >>> >Makefile:129: recipe for target 'all' failed >> >> >>> >make: *** [all] Error 2 >> >> >>> > >> >> >>> >Cheers, >> >> >>> >Dave >> >> >>> >> >> >>> >> >> > >> >> >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > > > -- > Makoto YUI <myui AT apache.org> > Principal Engineer, Arm Treasure Data. > http://myui.github.io/ > -- Makoto YUI <myui AT apache.org> Principal Engineer, Arm Treasure Data. http://myui.github.io/
