I ran RAT, and while I understand that a lot of the failures are coming from the 3rdparty directory, some of those are from files that should have the ASF license header such as pom files, docker files, project documentation (yes, MD files do accept apache license headers), Maybe the rat-exclude configuration on the project should be less permissive.
Based on this I am -1 (binding) On Wed, Feb 6, 2019 at 1:59 PM Steffen Rochel <steffenroc...@gmail.com> wrote: > > Dear community, > > This is a call for releasing Apache MXNet (incubating) 1.4.0, release > candidate 2 > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > > https://lists.apache.org/thread.html/4b445460d36d098be1c1e60e29869cf243e2bc37bd2b84ca7b1daab3@%3Cdev.mxnet.apache.org%3E > > > Result thread: > > https://lists.apache.org/thread.html/60e3272326cf93100370fa5b01a54a4b2f18f95462553b5a1acfd456@%3Cdev.mxnet.apache.org%3E > > The community raised the following issues which are not considered as > release stopper: > > 1. NOTICE year is wrong (2018): Not considered a stopping issue as release > was started in 2018. > 2. TVM NOTICE missing - TVM NOTICE file was added post the commit ID used > in MXNet v1.4.0.rc2 release, not considered a stopping issue > 3. build with make passes, but build with cmake failed in > 3rdparty/dmlc-core/test/unittest > 4. Recent MKLDNN upgrade prevents us from offering binary distribution for > earlier versions before OSX 10.13. > > > The source tarball, including signatures, digests, etc. can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc2/ > > The tag to be voted upon: > https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc2 > > The release hash is e999a46 > <https://github.com/apache/incubator-mxnet/commit/e999a46a8ca1383e78a9178dc65fa91e6e656c26> > : > > https://github.com/apache/incubator-mxnet/commit/e999a46a8ca1383e78a9178dc65fa91e6e656c26 > > KEYS file available: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS > > For information about the contents of this release, see: > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.4.0+Release+Notes > > The vote will be open at least 72 hours (Sunday February 10th 4pm PST) and > until sufficient votes are received. > > [ ] +1 release this package as 1.4.0 > [ ] +0 no opinion > [ ] -1 do not release this package because... > > Best regards, > Steffen -- Luciano Resende http://twitter.com/lresende1975 http://lresende.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
