+1 (binding) NOTICE, LICENSE, and DISCLAIMER files exist ASF Header exists and correct No executable files in source artifact
- Henry On Wed, Feb 27, 2019 at 9:54 AM Piyush Ghai <ghai.piy...@gmail.com> wrote: > Hi all, > > Thanks everyone for spending the time to test and vote. > > This vote passes with 5 +1 votes (4 binding) and no 0 or -1 votes. > > +1 votes > Henri Yandell / binding > Jason Dai / binding > Justin Mclean / binding > Michael Wall / binding > Sheng Zha > > 0 votes > No votes > > -1 votes > No votes > > I will move forward with publishing the official release now. > > Thanks, > Piyush > > > > On 2019/02/27 05:34:03, Sheng Zha <zhash...@apache.org> wrote: > > +1 > > > > And thanks to mentors and IPMC members for helping our release. NOTICE > year > > was caught in dev@ vote too. Master branch already has the fix [1] and > we > > promise to fix it in the next release. > > > > -sz > > > > [1] > > > https://github.com/apache/incubator-mxnet/pull/14043/files#diff-aa14599dc3fdfa9cc81a7c3c247b77b9L2 > > > > On Tue, Feb 26, 2019 at 7:47 PM Michael Wall <mjw...@gmail.com> wrote: > > > > > +1 binding > > > > > > Verified > > > - Release files in correct location > > > - Release files have the word incubating in their name > > > - Digital signature and hashes correct > > > - DISCLAIMER file exist > > > - LICENSE and NOTICE files exists > > > - LICENSE and NOTICE text correct > > > - Un-included software dependencies are not mentioned in LICENSE or > NOTICE > > > - License information is not mentioned in NOTICE > > > - All source files have ASF headers > > > - Contents of the release match with what's tagged in version control > > > - No unexpected binary files in the release > > > > > > Non verified > > > - NOTICE year not correct, unfortunate it was updated when the release > was > > > cut again > > > Is there any 3rd party code contained inside the release? If so: > > > - Was not able to compile. Stopped after 10 min, is > > > > > > > https://mxnet.incubator.apache.org/versions/master/install/build_from_source.html > > > right place to look? Instructions could be clearer > > > > > > Good work fixing the licensing. > > > > > > Mike > > > > > > On Tue, Feb 26, 2019 at 9:34 PM Justin Mclean < > jus...@classsoftware.com> > > > wrote: > > > > > > > HI,. > > > > > > > > +1 (binding) > > > > > > > > I didn’t have time to check all of the licenses so there may be some > work > > > > that’s still needed there, but it looks fairly comprehensive. > > > > > > > > I checked: > > > > - incubating in name > > > > - DISCLAIMER exists > > > > - LICENSE looks OK > > > > - NOTICE need year updating > > > > - No unexpected binary files > > > > - All ASF files have ASF headers > > > > - I didn’t compile from source and assume others have > > > > > > > > Thanks, > > > > Justin > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > >
