@Mohammad I really appreciate for the vote :) I have some questions in regarding to your suggestions.
1. We thought of removing binary LICENSE/NOTICE from the source release. However, there's one side effect that people cannot build a completely valid binary tarball out of the released source code (because it's missing binary LICENSE/NOTICE files). Spark and Flink project seemed to have the similar issue and they went with different approach. Spark removed binary LICENSE/NOTICE while Flink project includes the binary LICENSE/NOTICE files for the source code release. We preferred the latter approach (if it's not violating Apache terms) because it allows users to build the valid binary release tarball out of the released source code. (reference - spark issue: https://github.com/apache/spark/pull/22840) How do you think on this? I discussed with one of our mentors and he was fine with including binary LICENSE/NOTICE file to a source code release. 2. Can you provide me some example projects that are including version/commitid/tag for each listed dependencies as a reference? Also, are you referring to a binary LICENSE file or a source code LICENSE file? If for binary, I can get the versions for each dependency easily but tracking commitId + tag for each dependency(100+) will not be a simple task and I'm not sure if those information is required. Can you comment on this a bit more in detail? We can definitely address the issue for the next release. 3. I guess that the archives that you mention are probably sample data that are used for unit/integration tests. If we removed those archives, tests will probably fail. If possible, can you list some of archives that you have the concern with? We will evaluate if those archives are necessary to be include in the source release. Thank you! Best, Seunghyun On Mon, Mar 4, 2019 at 4:57 AM Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > +1 (binding) > > Checks Done: > - Hashes and signature is good > - Incubating in name > - LICENSE , NOTICE and DISCLAIMER exist > - Archive matching git tag > - Compiled from source and ran demos > > Suggestion : > - Binary LICENSE/NOTICE can be skipped for source release > - LICENSE file should have version/commitid/tag for each listed > dependencies > - Some archives for test purpose are present in the source release which > could be skipped if possible > > Regards > Asif > > On 2019/02/28 18:45:38, Seunghyun Lee <sn...@apache.org> wrote: > > Hi all, > > > > This is a call for vote to the release Apache Pinot (incubating) version > > 0.1.0. > > > > Apache Pinot (incubating) is a distributed columnar storage engine that > can > > ingest > > data in realtime and serve analytical queries at low latency. > > > > Pinot community has voted and approved this release. > > > > Vote thread: > > > https://lists.apache.org/thread.html/f136d3eaa9dfbab6e17b262a5542813099f2b128465d9d17ef69defd@%3Cdev.pinot.apache.org%3E > > > > Result thread: > > > https://lists.apache.org/thread.html/ce58034678349f82afc5f8ed2edd435875301183554f964778dffb7a@%3Cdev.pinot.apache.org%3E > > > > The release candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/pinot/apache-pinot-incubating-0.1.0-rc0 > > > > Git tag for this release: > > https://github.com/apache/incubator-pinot/tree/release-0.1.0-rc0 > > > > Git hash for this release: > > bbf29dc6e0f23383948f0db66565ebbdf383dd0d > > > > The artifacts have been signed with key: 44BA03AD164D961B, which can be > > found in the following KEYS file. > > https://dist.apache.org/repos/dist/release/incubator/pinot/KEYS > > > > Release notes: > > https://github.com/apache/incubator-pinot/releases/tag/release-0.1.0-rc0 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachepinot-1002 > > > > Documentation on verifying a release candidate: > > > https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate > > > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly, > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > Apache Pinot (incubating) team > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
