Hi Justin, 1. The Stack Overflow link we referenced in file [1] is an explanation of why this issue happens. We didn't use the code.
2. About files with author tags [6] - [24], it's because we used to add author names at the beginning of files as a convention. There are still some files keep it. They are not third party files Author of files [6], [7], [8], [21], [22], [24] is me (she...@apache.org) Author of files [9] - [20] is Deqing Li (deqin...@apache.org) Author of file [23] is Xiaohong Deng. She is one of our contributors, but not committer. We will remove the author tags in these files. 3. I wrote the code of file [28]. It's a parser of GEXF file format. The link in this file is broken. It's the specification of this format. The new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf 4. We will remove the function related to the code from Stack Overflow in file [5] and rewrite the code in file [26] before we start a new vote. Thanks. On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 binding (release includes Category X licensed code) > > I checked: > - signatures and hashes fine > - DISCLAIMER exists > - LICENSE may have some issues and missing some license information (see > below) > - NOTICE is fine > - all source file have ASF headers > - no unexpected binary files > > This file [1] contain code from [2] this is probably not compatible with > the ALv2 [3][4]. Also this file [5]. > > It’s unclear how this file [6] is licensed and it may incorrectly have an > ASF header. On closer inspection there see to be a number of files which > might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll > note these files have author tags. Where did these files come from? > > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is > not compatible with the Apache license. [27] > > Do you have permission to use this code [28] from the authors and is it in > under an Apache license as the file header states? > > There are also a number of references to http://echarts.baidu.com in the > code which should probably change. > > You might want to consider using the work in progress disclaimer [29] and > documenting the issues in that until they are fixed. > > Thanks, > Justin > > 1. ./src/component/tooltip/TooltipContent.js > 2. > https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore > 3. https://apache.org/legal/resolved.html#stackoverflow > 4. https://issues.apache.org/jira/browse/LEGAL-471 > 5. ./src/component/toolbox/feature/DataView.js > 6. ./src/chart/chord/chordCircularLayout.js > 7. ./src/util/KDTree.js > 8. ./src/util/quickSelect.js > 9. ./src/chart/tree/TreeSeries.js > 10. ./src/chart/tree/treeAction.js > 11. ./src/chart/tree/TreeView.js > 12. ./src/chart/sankey/sankeyAction.js > 13. ./src/chart/sankey/SankeySeries.js > 14. ./src/chart/sankey/sankeyLayout.js > 15. ./src/chart/sankey/SankeyView.js > 16. ./src/chart/sankey/sankeyVisual.js > 17. ./src/chart/themeRiver/themeRiverVisual.js > 18. ./src/chart/themeRiver/themeRiverLayout.js > 19. ./src/chart/themeRiver/ThemeRiverSeries.js > 20. ./src/chart/themeRiver/ThemeRiverView.js > 21. ./src/chart/heatmap/HeatmapLayer.js > 22, ./src/chart/chord/chordCircularLayout.js > 23. ./src/component/calendar.js > 24. ./src/data/Graph.js > 25. ./src/component/brush/selector.js > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322 > 27. https://apache.org/legal/resolved.html#cc-sa > 28. ./extension-src/dataTool/gexf.js > 29. https://incubator.apache.org/policy/incubation.html#disclaimers > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
