Hi Justin,
We are very thankful for your detailed analysis to help make Apache Hudi release be compliant. We will work on your licensing comments and create a new release candidate shortly. It would be immensely helpful for us if you can point us to any other issues/feedback concerning this release. This would help us address all of them in one go. Thanks, Balaji.V (on behalf ofApache Hudi PPMC) On 2019/10/10 21:44:31, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Sorry but it’s -1 (binding) due to license issues > > I checked: > - incubating in name > - signature and hash fine > - DISCLAIMER exist (but you might want to consider using the work in progress > disclaimer) > - LICENSE file is missing the appendix > - NOTICE is fine > - No unexpected binary file > - Source files have ASF headers > - Can compile from source > > This file [1] probably incorrectly has an ASF header on it, you may also want > to mention this file in LICENSE. It unclear what the license is of the code > contained in this file [2] are you sure you have permission to use this and > it’s under a compatible license? The code in here from stack overflow don’t > have a compatible license [3], see [4] (and [5]). > > Thanks, > Justin > > > 1. > ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java > 2. > ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java > 3. > ./hudi-0.5.0-incubating-rc5/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java > 4. https://www.apache.org/legal/resolved.html#stackoverflow > 5. https://issues.apache.org/jira/browse/LEGAL-471 > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
