Hi,
I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE looks good
- NOTICE is still incorrect
- No unexpected binary files
Some minor issues/questions:
- I did notice a directory called "3rdparty/dlpack/apps/from_numpy” is this
code from numpy?
- This file [1] has an ASF header is this correct?
- This file [2] has two copyright lines is this correct?
- This license [3] notes some exceptions to the ALv2 license, this might be an
issue and I suggest you ask on legal discuss if this is OK. I wouldn't let this
hold up a release.
- I noticed this line "MODULE_LICENSE("GPL”);” in 4. What's the history of this
file?
Thanks,
Justin
1. 3rdparty/cma//Makefile
2. 3rdparty/compiler-rt/builtin_fp16.h
3 ./licenses/LICENSE.builtin_fp16.txt
4. ./3rdparty/cma/cma.c
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
