Thanks all for participating in the vote. The results are as follows: 5 +1: Furkan Kamaci Larry McCay Paul King Jean-Baptiste Onofre Justin Mclean
0 +0 0 -1 The vote passes successfully. I will proceed with the release. Thanks all for the feedback, I’ll report back to the team. Cheers, Antoine > On Mar 15, 2020, at 2:29 AM, Paul King <pa...@asert.com.au> wrote: > > I had the same questions Justin mentioned wrt gossip and relayer but > forgot to mention that. > One approach could be to have your artifacts split into sources and > distributions subdirectories (or similar names). > > Cheers, Paul. > > On Sun, Mar 15, 2020 at 5:37 PM Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi, >> >> +1 (binding) >> >> I checked only the source release: >> - incubating in name >> - signature and hashes good >> - DISCLAIMER exists >> - LICENSE and NOTICE are good >> - No unexpected binary files >> - Hard to tell if any files are missing headers due to large number of >> Json files >> - Didn’t compile from source >> >> It a little unclear from the names if if gossip and relayer are binary or >> source artefacts, you might want to correct that. >> >> Also you might want consider removing the large amount of test resource >> form the source release, IMO users generally want to build the release not >> test it ands it on the rather large size with some test file being over 1Mb. >> >> Thanks, >> Justin >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
