Hi,

-1 (binding) due to licensing concerns. You might want to consider using the 
WIP disclaimer

I checked:
- incubating in name
- signatures and hash correct
- DISCLAIMER exists
- LICENSE is missing a number of 3rd party licenses
- NOTICE mentions MIT licensed software there’s no need to do this
- No unexpected binary files (but it would still be a good idea to rename that 
.bin files)
- Can compile from source

I think the a number of licensing issue that need to be resolved here:
- Where did this geo son files come from? [1] it seem it might be from here? 
(which states it’s legal status is dubious)
- This file [2] come from the moby project and need to be mentioned in LICENSE
- These file [4][5][6][7] are of unclear origin and license. One come from [8] 
where the license is blank.
- This file [9] copied from [10] which terms of use state " User’s personal, 
non-commercial use, without any right to resell or redistribute them or to 
compile or create derivative works therefrom” which would be incompatible with 
the ALv2.
- A simpler situation exists with [11] as with [9]

Thanks,
Justin

1.  ./nlpcraft/src/main/resources/geo/*
2. https://github.com/johan/world.geo.json
3.   ./nlpcraft/src/main/resources/moby/*
4. ./nlpcraft/src/main/resources/opennlp/en-lemmatizer.dict
5. ./nlpcraft/src/main/resources/opennlp/models.txt
6. ./nlpcraft/src/main/resources/spell/dictionary.json
7. ./nlpcraft/src/main/resources/synonyms/synonyms.json
8. https://github.com/richardwilly98/elasticsearch-opennlp-auto-tagging
9 
./nlpcraft/src/main/scala/org/apache/nlpcraft/server/geo/tools/unstats/codes.txt
10. http://unstats.un.org/unsd/methods/m49/m49alpha.htm
11. 
./nlpcraft/src/main/scala/org/apache/nlpcraft/server/geo/tools/unstats/subcontinents.txt



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to