Dave, I appreciate and thank you for your change of vote. I already have changed how we generate the NOTICE in our binary distribution - next time, I might run it by the list here before the vote starts to discuss its format.
> On Nov 22, 2020, at 11:32 AM, Dave Fisher <w...@apache.org> wrote: > > Hi Antoine, > > With your explanations I’m changing my VOTE: > > +1 (binding) > > Regards, > Dave > >> On Nov 21, 2020, at 3:42 PM, Antoine Toulme <anto...@toulme.name> wrote: >> >> >> >>> On Nov 21, 2020, at 2:50 PM, Dave Fisher <w...@apache.org> wrote: >>> >>> >>> >>>> On Nov 21, 2020, at 2:25 PM, Antoine Toulme <anto...@toulme.name> wrote: >>>> >>>> The binaries are generated by the build. >>> >>> I ran a build the jars were generated, but the scripts in the bin are not >>> anywhere in the source tree. Those aren’t built I have no idea where the >>> binary convenience got those scripts. >> The scripts are generated by the application plugin of Gradle: >> https://docs.gradle.org/current/userguide/application_plugin.html >> <https://docs.gradle.org/current/userguide/application_plugin.html> >> >>> >>>> >>>> I thought the build was a vote on the sources and their distribution, >>>> while binaries are convenience. >>> >>> They are a convenience, but if you are using ASF resources then the >>> licensing needs to properly follow policy. >> OK. >>> >>>> >>>> Do you have an example of (3)? >>> >>> leveldbjni-all-1.8.jar is BSD 3-Clause >>> Jetty is dual licensed - you should declare that you are choosing AL2. >>> Jersey is quad licensed - … >>> Jaxb is CDDL 1.1, but used to be GPL >>> Javax is CDDL and GPL2 so you definitely need to declare. >>> Javasist is triple licensed - AL2, LGPL2, and MPL 1.1 so ... >>> Jakarta are EPL2 and GPL2. >>> >>> I found this information quickly using mvnrepository.com >>> >>> It’s all about easily assuring users of the binary package what the terms >>> are. >>> >>> These classes can be used for Binaries >>> Class A licenses: https://www.apache.org/legal/resolved.html#category-a >>> Class B licenses: https://www.apache.org/legal/resolved.html#category-b >>> Sources must not contain Class B. >>> >>> Class X cannot be used: >>> https://www.apache.org/legal/resolved.html#category-x >>> <https://www.apache.org/legal/resolved.html#category-x> >> >> Ah, we generate a license report but don’t include it. We can fix that in >> the next release. >>> >>> Regards, >>> Dave >>> >>>> >>>>> On Nov 21, 2020, at 2:20 PM, Dave Fisher <w...@apache.org> wrote: >>>>> >>>>> Hi - >>>>> >>>>> Incubator in name, Signatures, Hashes, NOTICE, DISCLAIMER are in place. >>>>> >>>>> Source package LICENSEs are fine. >>>>> >>>>> Binaries - >>>>> (1) bin directory - where are the sources for the scripts and bat files >>>>> in the Source Release? >>>>> (2) bin directory - what is the license for these files? >>>>> (3) LICENSE is identical to source release. The binary LICENSE and NOTICE >>>>> need to reflect everything included in the lib directory. >>>>> >>>>> I’m -0 (binding) on this release, I think these 3 issues do need to be >>>>> addressed. >>>>> >>>>> If other IPMC members are willing to VOTE +1 that’s ok with me. >>>>> >>>>> Regards, >>>>> Dave >>>>> >>>>>> On Nov 19, 2020, at 11:16 AM, Antoine Toulme <anto...@toulme.name> wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> We're voting on the source distributions available here: >>>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/1.3.0-incubating/ >>>>>> The release tag is present here: >>>>>> https://github.com/apache/incubator-tuweni/releases/tag/v1.3.0-incubating-rc >>>>>> >>>>>> Please review and vote as appropriate. >>>>>> >>>>>> The following changes were made since 1.2.0: >>>>>> >>>>>> * Update to support Sodium 1.0.18 >>>>>> (https://github.com/apache/incubator-tuweni/pull/164 >>>>>> <https://github.com/apache/incubator-tuweni/pull/164>) >>>>>> * Base58 encoding support >>>>>> (https://github.com/apache/incubator-tuweni/pull/150 >>>>>> <https://github.com/apache/incubator-tuweni/pull/150>) >>>>>> * eth65 support (https://github.com/apache/incubator-tuweni/pull/152 >>>>>> <https://github.com/apache/incubator-tuweni/pull/152>) >>>>>> * Add a helper to transform a SECP256K1 public key into an Ethereum >>>>>> address (https://github.com/apache/incubator-tuweni/pull/154 >>>>>> <https://github.com/apache/incubator-tuweni/pull/154>) >>>>>> * Add a discv5 scraper >>>>>> (https://github.com/apache/incubator-tuweni/pull/157 >>>>>> <https://github.com/apache/incubator-tuweni/pull/157>) >>>>>> * Upgrade Bouncy Castle >>>>>> (https://github.com/apache/incubator-tuweni/pull/160 >>>>>> <https://github.com/apache/incubator-tuweni/pull/160>) >>>>>> * Upgrade Error Prone >>>>>> (https://github.com/apache/incubator-tuweni/pull/165 >>>>>> <https://github.com/apache/incubator-tuweni/pull/165>) >>>>>> * Add Windows CI test build >>>>>> (https://github.com/apache/incubator-tuweni/pull/167 >>>>>> <https://github.com/apache/incubator-tuweni/pull/167>) >>>>>> * Add binary snapshots >>>>>> (https://github.com/apache/incubator-tuweni/issues/161 >>>>>> <https://github.com/apache/incubator-tuweni/issues/161>) >>>>>> * Misc fixes and clean ups to docs >>>>>> >>>>>> Here is the release thread on the d...@tuweni.apache.org >>>>>> <mailto:d...@tuweni.apache.org> list: >>>>>> https://lists.apache.org/thread.html/r6ed976ff5519ea7227b5676e6a0af382afbb075a1bff1def384737b1%40%3Cdev.tuweni.apache.org%3E >>>>>> >>>>>> The release vote has passed with the following votes >>>>>> (https://lists.apache.org/thread.html/r32e2b69d7c5314366304733dfedc58672db9acbf2dabcff1b9eea00c%40%3Cdev.tuweni.apache.org%3E >>>>>> >>>>>> <https://lists.apache.org/thread.html/r32e2b69d7c5314366304733dfedc58672db9acbf2dabcff1b9eea00c@%3Cdev.tuweni.apache.org%3E>) >>>>>> 3 +1: >>>>>> Antoine Toulme >>>>>> Rob Dawson >>>>>> Danno Ferrin >>>>>> 0 +0 >>>>>> 0 -1 >>>>>> >>>>>> The release vote is open at least until 11/25 12pm PST time. >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Antoine >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
