Hi,
Here is my checking list,
[x] Download links are valid.
[ ] Checksums and PGP signatures are valid.
[x] LICENSE and NOTICE files are correct (From[1]).
[x] All files have license headers if necessary.
[x] Install successfully.
PGP signatures are well. However, I got the following exceptions when checksums
on macOS.
Did I miss something?
▶ shasum -c apache-liminal-0.0.1rc4-INCUBATING-source.tar.gz.sha512
shasum: apache-liminal-0.0.1rc4-INCUBATING-source.tar.gz.sha512: No such file
or directory
⍉
▶ shasum -a 512 -c apache-liminal-0.0.1rc4-INCUBATING-source.tar.gz.sha512
shasum: apache-liminal-0.0.1rc4-INCUBATING-source.tar.gz.sha512: No such file
or directory
[1]
https://github.com/apache/incubator-liminal/commit/8441a3f428982888fe70ce76a89506a80a43845d
----------------------------------------------------------------
Juan Pan (Trista)
Senior DBA & PMC of Apache ShardingSphere
E-mail: panj...@apache.org
On 01/28/2021 09:12，Justin Mclean<jus...@classsoftware.com> wrote：
Hi,
+1 of the source release, but -1 on the whl file.
For the source release I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER (WIP) exists but still has "List of known issues goes here”. You
need to mention what issue this release has.
- LICENSE is good
- NOTICE is OK no need for "I. Included Software”
- All source files have ASF headers
- No unexpected binary files
For the whl file, everything is fine as above, and it now does contain the
LICENSE and NOTICE but is missing a DISCLAIMER file. All releases must contain
an incubating disclaimer.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
