+1 (binding) Checked: - LICENSE and NOTICE seem okay - DISCLAIMER-WIP exists - Incubating in name - Checksum and signature okay - No unexpected binary file - Built shared library using cmake (without CUDA) - Built Java/Scala jars (also works for Groovy)
Comments: * As others have noted, please fix LICENSE, NOTICE and DISCLAIMER-WIP files moving forward. * LICENSE file mentions 3rdparty/tvm/3rdparty/rang as "Unlicense". It would be good to clarify that. * Also a minor thing which could be improved: "What's New" section in README.md stops at version 1.5.1. It would be great to keep that section updated or point to some website if that info is elsewhere. * You reference KEYS in dev space but also have one in the release space at: https://dist.apache.org/repos/dist/release/incubator/mxnet/. I'd encourage you just to use the release one (keeping it updated as needed) and delete the dev one. This would avoid having two (potentially out of sync) sources of truth. * I had to manually copy some .a/.so files from root directory to lib (I could have done a step wrong) * I had to use JDK8 to build jars (didn't see that in instructions I was following but I could have missed it) * Built jars had version INTERNAL, I was expecting 1.8.0.rc3 or similar * I was planning to run my Groovy data science example against the jar but the produced jars didn't seem complete (perhaps my lack of understanding of steps required) Cheers, Paul. On Mon, Jan 25, 2021 at 12:37 AM Skalicky, Sam <sska...@amazon.com.invalid> wrote: > Dear community, > > This is a call for a releasing Apache MXNet (incubating) 1.8.0, release > candidate 3. > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > > https://lists.apache.org/thread.html/r42511b3c24a6df9f07a502dd0afd9db514b2592c30c26b90ffbd36ce%40%3Cdev.mxnet.apache.org%3E > > Result thread: > > https://lists.apache.org/thread.html/r4aa42956b2a9c417e10043dd12a16e926d0a11e8b0e7befeac3fb242%40%3Cdev.mxnet.apache.org%3E > > The source tarball, including signatures, digests, etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.8.0.rc3 > > The tag to be voted upon is 1.8.0.rc3: > https://github.com/apache/incubator-mxnet/releases/tag/1.8.0.rc3 > > The release hash is 2fc0706874531fdfdbe49819eae0c88f8016eee3: > > https://github.com/apache/incubator-mxnet/commit/2fc0706874531fdfdbe49819eae0c88f8016eee3 > > KEYS file available: > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS > > For information about the contents of this release, see: > https://cwiki.apache.org/confluence/display/MXNET/1.8.0+Release+Notes > > Here are the changes comparing to 1.8.0.rc2: > * Updated LICENSE & rat checker > * Extensions bugfixes > * fix for R builds > * Upgrade to oneDNN v1.7 with required bugfixes > * Fix for testing with CUDA 11, remove cleanup on side threads > * Fix for building CUDA 11 with Windows > * Remove temporary fix for RNN in MKLDNN > > The vote will be open for 72 hours. > [ ] +1 release this package as ######### > [ ] +0 no opinion > [ ] -1 do not release this package because... > > Best regards, > Sam Skalicky >
