Hello Liu! Thanks for taking a look into this. The files mentioned are in JSON format which does not allow for comments. As far as we know, the ASF header is not able to be included in this file type. See the linked example from the package.json file in Apache Airflow <https://github.com/apache/airflow/blob/main/airflow/ui/package.json>.
Best, Gedd Johnson On Fri, Jun 18, 2021 at 3:52 AM Xun Liu <liu...@apache.org> wrote: > Hi, Johnson > > I have checked the following items: > > - Incubating in name > - NOTICE is fine > - DISCLAIMER exists > - All links are valid > - No unexpected JS files > > BUT, This file does not have ASF headers, Please fixed it. > > https://github.com/apache/incubator-flagon-useralejs/blob/master/package-lock.json > > https://github.com/apache/incubator-flagon-useralejs/blob/master/cypress.json > > https://github.com/apache/incubator-flagon-useralejs/blob/master/package.json > > Xun Liu > Best regards > > On Thu, Jun 17, 2021 at 2:42 PM Gedd Johnson <geddjohns...@gmail.com> > wrote: > > > Hi Folks, > > > > Please VOTE on the Apache Flagon UserALE.js 2.2.0 Release Candidate #3. > > > > A VOTE was carried out on dev@flagon with the following results: > > > > [ 4 ] +1, let's get it released!!! (+2 (IPMC/Binding) +2 PPMC) > > [ 0 ] +/-0, fine, but consider to fix few issues before... > > [ 0 ] -1, nope, because... (and please explain why) > > > > We require +1 IPMC/Binding VOTE to Release. > > > > The VOTE thread can be found here: > > > > > https://lists.apache.org/thread.html/rfa74ac6182a195facddecb4218f12b1354c02a0eee4bbb24d8d4d024%40%3Cdev.flagon.apache.org%3E > > (note > > that the thread got a little convoluted, this link reflects the thread > for > > 2.2.0 RC3) > > > > About Flagon: http://flagon.incubator.apache.org/ > > > > This Minor release includes: > > > > 1. Adding a page load log feature > > 2. Refactoring the build pipeline using Rollup > > 3. Adding a journey testing suite > > 4. Fixing a bug with sendOnClose > > > > We solved 21 issues: > > https://github.com/apache/incubator-flagon-useralejs/projects/7 > > > > Git source tag (2b996df): > > > https://github.com/apache/incubator-flagon-useralejs/releases/tag/2.2.0-RC3 > > > > Staging repo: https://dist.apache.org/repos/dist/dev/incubator/flagon/ > > > > Source Release Artifacts: > > > > > https://dist.apache.org/repos/dist/dev/incubator/flagon/apache-flagon-useralejs-incubating-2.2.0-RC3/ > > > > PGP release keys (signed using A88C905BD4516D4C): > > https://dist.apache.org/repos/dist/dev/incubator/flagon/KEYS > > > > Link to successful Github CI Build: > > https://github.com/apache/incubator-flagon-useralejs/actions > > > > Reference the useralejs testing framework to assist in your unit and > > integration tests: > > > > > https://cwiki.apache.org/confluence/display/FLAGON/UserALE.js+Testing+Framework > > > > Vote will be open for 72 hours. Please VOTE as follows: > > > > [ ] +1, let's get it released!!! > > [ ] +/-0, fine, but consider to fix few issues before... > > [ ] -1, nope, because... (and please explain why) > > > > Along with your VOTE, please indicate testing and checks you've made > > against build artifacts, src, and documentation: > > > > [ ] Build and Unit Tests Pass > > [ ] Integration Tests Pass > > [ ] "Incubating" in References to Project and Distribution File Names > > [ ] Signatures and Hashes Match Keys > > [ ] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release > > Packages > > [ ] DISCLAIMER, LICENSE, and NOTICE are consistent with ASF and Incubator > > Policy > > [ ] CHANGELOG included with release distribution > > [ ] All Source Files Have Correct ASF Headers > > [ ] No Binary Files in Source Release Packages > > > > Thank you to everyone that is able to VOTE as well as everyone that > > contributed to Apache Flagon UserALE.js (Incubating) 2.2.0 > > >
