HI Justin, Thanks for the check, we will look into it. In the client zip we have a THIRD-PARTY.txt which should list all dependencies and their licenses [1]. I suppose this should then be included in the LICENSE file and we should go over all the dependencies to see what needs to be included in the notice file?
Just to make sure we get it right next release. Cheers, Hans [1] https://github.com/apache/incubator-hop/blob/master/assemblies/static/src/main/resources/THIRD-PARTY.txt On Tue, 3 Aug 2021 at 08:59, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) but LICENSE needs to be updated and there’s a few piece of > 3rd party code who licenses need to be clarified. Please fix these before > ether next release. > > I checked: > - incubating in name > - signatures and hashes are fine > - There is a 3rd party file here [1] that is not mentioned in LICENSE > - All file have ASF headers > - No unexpected binary files > - did not compile > > There is also code in here [2][3] that has been copied form [4] and is an > unknown license. My guess this is OK to use [5] but it should be mentioned > in LICENSE. There is also 3rd party code here [6]. How is this licensed? Is > there any other 3rd party code in the release? > > The LICENSE and NOTICE of apache-hop-client-0.99-incubating.zip are not > correct as they don’t reflect what is in that release artefact. The LICENSE > and NOTICE of binary files is often different to the source as they can > contain a lot more more 3rd party software. > > Kind Regards, > Justin > > 1. ./.mvn/wrapper/MavenWrapperDownloader.java > 2. > ./apache-hop-0.99-incubating/plugins/transforms/mailvalidator/src/main/java/org/apache/hop/pipeline/transforms/mailvalidator/MailValidation.java > 3. > ./apache-hop-0.99-incubating/plugins/actions/mailvalidator/src/main/java/org/apache/hop/workflow/actions/mailvalidator/MailValidation.java > 4. https://www.rgagnon.com/javadetails/java-0452.html > 5. https://www.rgagnon.com/varia/faq-e.html > 6 > ./apache-hop-0.99-incubating/core/src/main/java/org/apache/hop/core/util/Utils.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
