Thank you so much! We will change name of artifacts to follow the naming rules. And this vote will be cancelled.
-- 此致！Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org At 2022-03-05 20:55:29, "Cheng Pan" <pan3...@gmail.com> wrote: >BTW, there are other examples and I think they can help you to think >about how to name your project components. > >1. spark-cassandra-connector_2.12[1], does not make the spark minor >version be part of the artifact name, but documents the support >matrix[2] instead. >2. elasticsearch-spark-20_2.12[3], elasticsearch-spark-30_2.12[4], >adds the minimal supported spark minor version into the artifact name, >but uses `20` to represent spark 2.0 >3. spark-sql-kafka-0-10_2.12, similar to elasticsearch, but uses >`0-10` to represent kafka 0.10 >4. kyuubi-extension-spark-3-1_2.12, similar to spark-sql-kafka > >[1] >https://mvnrepository.com/artifact/com.datastax.spark/spark-cassandra-connector_2.12/3.1.0 >[2] https://github.com/datastax/spark-cassandra-connector >[3] >https://mvnrepository.com/artifact/org.elasticsearch/elasticsearch-spark-20_2.12/8.0.1 >[4] >https://mvnrepository.com/artifact/org.elasticsearch/elasticsearch-spark-30_2.12/8.0.1 >[5] >https://mvnrepository.com/artifact/org.apache.spark/spark-sql-kafka-0-10_2.12/3.2.1 >[6] >https://mvnrepository.com/artifact/org.apache.kyuubi/kyuubi-extension-spark-3-1_2.12/1.4.1-incubating > >Thanks, >Cheng Pan > >On Sat, Mar 5, 2022 at 8:36 PM Cheng Pan <pan3...@gmail.com> wrote: >> >> Usually Spark keeps good binary compatibility in the same minor >> versions, it says that the downstream project builds against spark >> 3.1.2 is also expected to work with spark 3.1.3, but not spark 3.2.x, >> so, it's rare to keep a patch version in the name. >> I think Apache Iceberg does a good job in this area[1][2], I would >> suggest changing the artifact name to >> `doris-spark-connector-3.1_2.12`, and the GAV(group, artifact, >> version) should be >> `org.apache.doris:doris-spark-connector-3.1_2.12:1.0.0`. >> >> [1] >> https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark-runtime-3.1_2.12/0.13.1 >> [2] >> https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark-runtime-3.2_2.12/0.13.1 >> >> Thanks, >> Cheng Pan >> >> On Sat, Mar 5, 2022 at 8:13 PM 陈明雨 <morning...@163.com> wrote: >> > >> > Hi Cheng Pan: >> > Thanks for the reminder, I didn't know there was such a rule before. >> > Our current version names are: >> > doris-spark-connector-3.1.2-2.12-1.0.0 >> > Among them, 3.1.2 is the spark version, 2.12 is the scala version, and >> > 1.0.0 is the version of the connector itself. >> > What we need to do is to change the version name to the following: >> > doris-spark-connector-1.0.0-3.1.2_2.12 >> > >> > >> > Is that right? >> > >> > >> > >> > >> > -- >> > >> > 此致！Best Regards >> > 陈明雨 Mingyu Chen >> > >> > Email: >> > morning...@163.com; >> > morningman....@gmail.com >> > >> > >> > >> > >> > >> > At 2022-03-05 16:17:17, "Cheng Pan" <pan3...@gmail.com> wrote: >> > >Hi, >> > > >> > >One question about the name of artifacts, it seems does not follow the >> > >common practice, the recommended artifact name pattern is >> > >"{aritifact_name}_{scala_binary_version}", e.g. `spark-core_2.12`, >> > >this is the default behavior defined in sbt[1] and the de facto >> > >artifact name pattern in scala world, and the mvnrepository.com can >> > >recognize and extract scala binary versions from the name. >> > > >> > >[1] >> > >https://www.scala-sbt.org/1.x/docs/Artifacts.html#Modifying+default+artifacts >> > >[2] https://mvnrepository.com/artifact/org.apache.spark/spark-core >> > > >> > >Thanks, >> > >Cheng Pan >> > > >> > >On Sat, Mar 5, 2022 at 3:56 PM 陈明雨 <morning...@163.com> wrote: >> > >> >> > >> Dear IPMC, >> > >> >> > >> >> > >> >> > >> >> > >> This is a call for vote to release Spark Connectors v1.0.0 for Apache >> > >> Doris(Incubating). >> > >> >> > >> There are 2 outputs for different Spark and Scala versions: >> > >> >> > >> - apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating >> > >> >> > >> - apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating >> > >> >> > >> >> > >> >> > >> >> > >> This is the first release version of spark connector, and the vote >> > >> thread in dev@doris is here[1]. >> > >> >> > >> We have just moved the code from[2] to [3]. >> > >> >> > >> >> > >> >> > >> >> > >> The release candidates: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/incubator/doris/spark-connector/1.0.0/ >> > >> >> > >> >> > >> >> > >> >> > >> Maven 2 staging repository: >> > >> >> > >> https://repository.apache.org/content/repositories/orgapachedoris-1006/org/apache/doris/doris-spark-connector/ >> > >> >> > >> >> > >> >> > >> >> > >> Git tag for the release: >> > >> >> > >> https://github.com/apache/incubator-doris-spark-connector/tree/2.3.4-2.11-1.0.0 >> > >> >> > >> https://github.com/apache/incubator-doris-spark-connector/tree/3.1.2-2.12-1.0.0 >> > >> >> > >> >> > >> >> > >> >> > >> Keys to verify the Release Candidate: >> > >> >> > >> https://downloads.apache.org/incubator/doris/KEYS >> > >> >> > >> >> > >> >> > >> >> > >> Look at here for how to verify this release candidate: >> > >> >> > >> http://doris.incubator.apache.org/community/release-and-verify/release-verify.html >> > >> >> > >> >> > >> >> > >> >> > >> The vote will be opened for at least 72 hours or until necessary number >> > >> of votes are reached. >> > >> >> > >> Please vote accordingly: >> > >> >> > >> >> > >> >> > >> >> > >> [ ] +1 approve >> > >> >> > >> [ ] +0 no opinion >> > >> >> > >> [ ] -1 disapprove with the reason >> > >> >> > >> >> > >> >> > >> >> > >> [1] https://lists.apache.org/thread/0n348fjrbmf4lxwz7xvvomltkmbh7db6 >> > >> >> > >> [2] https://github.com/apache/incubator-doris >> > >> >> > >> [3] https://github.com/apache/incubator-doris-spark-connector >> > >> >> > >> >> > >> >> > >> >> > >> -- >> > >> >> > >> 此致！Best Regards >> > >> >> > >> 陈明雨 Mingyu Chen >> > >> >> > >> >> > >> >> > >> >> > >> Email: >> > >> >> > >> chenmin...@apache.org >> > > >> > >--------------------------------------------------------------------- >> > >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > >For additional commands, e-mail: general-h...@incubator.apache.org > >--------------------------------------------------------------------- >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >For additional commands, e-mail: general-h...@incubator.apache.org
