+1 (binding) I checked: - Vote thread and result looks ok, - LICENSE, NOTICE, DISCLAIMER are in place, - Checksum and gpg signatures are valid, - Compile success on my Mac with JDK 8;
Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC, Apache Incubator PMC, Email: shaofeng...@apache.org Apache Kylin FAQ: https://kylin.apache.org/docs/gettingstarted/faq.html Join Kylin user mail group: user-subscr...@kylin.apache.org Join Kylin dev mail group: dev-subscr...@kylin.apache.org cas...@apache.org <cas...@apache.org> 于2022年6月30日周四 17:06写道： > Hi Justin > > Thanks for your advice. > I have modified the README.md [1] to optimize the points you mentioned. > > Best Regards! > Chen Xia > > 1 https://github.com/apache/incubator-linkis/blob/master/README.md > > Justin Mclean <jus...@classsoftware.com> 于2022年6月30日周四 11:26写道： > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes are fine > > - LICENSE and NOTICE are fine > > - No unexpected binary files > > - ASF headers where needed > > - Can compile from source > > > > In the readme it sates: > > "Please go to the [Linkis Releases Page]( > > https://github.com/apache/incubator- /releases) to download a compiled > > distribution or a source code package of Linkis.” > > > > Please do not point users to guthub as a primary way to obtain releases, > > please point them to the ASF official release area. It also a good idea > to > > tell people how they can verify releases. > > > > It would also be best if the full instructions on how to compile were > > included in the README. Instructions at a URL may change over time and > may > > not work for previous versions of the software. > > > > Kind Regards, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
